sspBC Bid Adapter: add support for topicsFpdModule #10416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgirardi
approved these changes
Sep 5, 2023
| @@ -199,6 +199,22 @@ const applyClientHints = ortbRequest => { | |||
| ortbRequest.user = { ...ortbRequest.user, ...ch }; | |||
| }; | |||
|
|
|||
| const applyTopics = (validBidRequest, ortbRequest) => { | |||
| const userData = validBidRequest.ortb2?.user?.data || []; | |||
| const topicsData = userData.filter(dataObj => { | |||
There was a problem hiding this comment.
the ortb2 object you get as input is meant to be usable as-is for your ORTB exchange, so I'm always curious to learn why the extra processing.
From what I see here you prefer to:
- not get all the available user data segments, but only topics;
- not get information about who provided the topics (
data[].name).
Both choices seem odd to me, which is why I note them here, but of course you're free to make them.
There was a problem hiding this comment.
Our exchange is, unfortunately, not fully ortb-compliant - that's why we:
a) trim data in topics
b) custom-build other user segments (see applyClientHints etc)
The next major version of the adapter should use ortbConverter, but we're waiting for the changes on the backend (to eliminate the need for overrides on the adapter side).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Add support for User.data segments 600-609 (topics data created by topicsFpdModule.js).
Reformat data so it's properly parsed by sspBC exchange.