SmileWanted Bid Adapter : add gvlid #10423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxSmileWanted
changed the title
ChrisHuie
changed the title
ChrisHuie
changed the title
ChrisHuie
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In the context of ensuring compliance with the IAB's Transparency and Consent Framework (TCF) v2.2, it was identified that the
smilewantedadapter lacked a definedgvlid. This omission led to issues with the handling of user consent, resulting in warnings and the adapter not being called as expected.This PR addresses the oversight by adding the
gvlidfor SmileWanted, which is639, to the adapter's definition. It's related to the issue reported here.Changes
gvlid: 639to thesmilewantedbid adapter.Expected Impact
WARNING: Activity control: TCF2 denied 'fetchBids' for 'bidder.smilewanted'.smilewantedadapter can participate in auctions when appropriate consent or legitimate interest is established.