Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBjs Core : clean up utils.js #10441

Merged
merged 24 commits into from
Sep 21, 2023
Merged

PBjs Core : clean up utils.js #10441

merged 24 commits into from
Sep 21, 2023

Conversation

dgirardi
Copy link
Collaborator

@dgirardi dgirardi commented Sep 6, 2023

Type of change

  • Refactoring (no functional changes, no api changes)

Description of change

Refactor utils.js to be smaller - this gets about 2KB off prebid core after minification.

Other information

Closes #10392

@ChrisHuie ChrisHuie changed the title Clean up utils.js PBjs Core : clean up utils.js Sep 13, 2023
Copy link
Contributor

@ncolletti ncolletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice changes, looks good to me

@ncolletti
Copy link
Contributor

@dgirardi there are a few conflicts to resolve prior to merging

@ChrisHuie ChrisHuie merged commit 99d58dd into prebid:master Sep 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up utils.js to reduce bundle size
3 participants