Core: do not log errors about invalid XML when serializing XHR objects #10483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dgirardi Thanks for this! It appears to work in my local testing - the error is gone. For context, when testing an upgrade from 7.53.0 to 8.13.0 I experienced the following new error: |
ChrisHuie
approved these changes
Sep 18, 2023
ChrisHuie
added
bugfix
needs 2nd review
jsnellbaker
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Since #10340, serializing a (fake) XHR object will log an error for responses that are not XML-formatted. This change leaves the error message only for the case when someone is explicitly asking for XML.