update appnexus PBS default configs #10503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgirardi
reviewed
Sep 19, 2023
| @@ -1,27 +1,18 @@ | |||
| // accountId and bidders params are not included here, should be configured by end-user | |||
| export const S2S_VENDORS = { | |||
| 'appnexus': { | |||
There was a problem hiding this comment.
this is used by some integration examples and unit tests, those should probably also be updated.
There was a problem hiding this comment.
Pushed a change to get the remaining references
SyntaxNode
approved these changes
Sep 19, 2023
dgirardi
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This PR removes a fully deprecated appnexus PBS endpoint config and adds the syncEndpoint for the appnexus PSP default config.
Confirmed these changes with @SyntaxNode