Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alkimi bid adapter: Resolve AUCTION_PRICE macro for VAST ads #10536

Merged
merged 39 commits into from
Sep 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
10ae6ca
Merge pull request #1 from prebid/master
pro-nsk Nov 15, 2021
325c162
Alkimi bid adapter
Nov 15, 2021
df09e0d
Alkimi bid adapter
pro-nsk Nov 17, 2021
b3e3688
Alkimi bid adapter
pro-nsk Nov 17, 2021
144cda7
alkimi adapter
pro-nsk Feb 7, 2022
c14dcd2
onBidWon change
pro-nsk Feb 8, 2022
ddec997
sign utils
pro-nsk Feb 8, 2022
068c546
auction ID as bid request ID
pro-nsk Feb 24, 2022
df2d98b
Merge pull request #2 from prebid/master
pro-nsk Apr 26, 2022
bf432c4
unit test fixes
pro-nsk Apr 27, 2022
76afe9b
change maintainer info
pro-nsk May 11, 2022
2e6c2ac
Merge branch 'master' into master
pro-nsk May 11, 2022
7dc389d
Updated the ad unit params
kalidas-alkimi May 16, 2022
74a85e4
Merge remote-tracking branch 'upstream/master'
kalidas-alkimi May 17, 2022
b6a9dc4
Merge pull request #4 from prebid/master
pro-nsk May 31, 2022
8675d2a
Merge pull request #5 from prebid/master
mihanikw2g May 31, 2022
ea2a9bf
features support added
mihanikw2g May 31, 2022
53e1ecc
Merge branch 'master' into master
pro-nsk Jun 16, 2022
011053e
Merge pull request #7 from prebid/master
pro-nsk Aug 24, 2022
74f8e12
transfer adUnitCode
pro-nsk Aug 24, 2022
0a0d8e8
transfer adUnitCode: test
pro-nsk Aug 24, 2022
afb97d8
Merge pull request #9 from prebid/master
pro-nsk Dec 21, 2022
41b6ca3
AlkimiBidAdapter getFloor() using
pro-nsk Dec 22, 2022
cabf081
Merge pull request #11 from prebid/master
pro-nsk Feb 7, 2023
dfcf4e8
ALK-504
mw2g Feb 8, 2023
1a9fe87
ALK-504
mw2g Feb 13, 2023
8a867e9
Merge pull request #12 from prebid/master
mihanikw2g Feb 22, 2023
b137e3d
Merge branch 'master' of github.com:prebid/Prebid.js into prebid-master
pro-nsk Jul 12, 2023
3a9e4dd
Merge branch 'prebid-master'
pro-nsk Jul 12, 2023
b725632
Support new OpenRTB parameters
pro-nsk Jul 13, 2023
36c2b78
Support new oRTB2 parameters
pro-nsk Jul 24, 2023
77c4113
remove pos parameter
pro-nsk Jul 31, 2023
1ca3501
Merge pull request #14 from prebid/master
pro-nsk Aug 23, 2023
1f46320
Merge pull request #15 from prebid/master
pro-nsk Aug 24, 2023
f32111f
Add gvl_id into Alkimi adapter
pro-nsk Aug 24, 2023
82cf955
Merge pull request #16 from prebid/master
pro-nsk Sep 19, 2023
57bd144
Insert keywords into bid-request param
kalidas-alkimi Sep 21, 2023
1fdf90b
Merge pull request #17 from prebid/master
pro-nsk Sep 25, 2023
3b63de9
Resolve AUCTION_PRICE macro on prebid-server for VAST ads
kalidas-alkimi Sep 26, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 8 additions & 17 deletions modules/alkimiBidAdapter.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {registerBidder} from '../src/adapters/bidderFactory.js';
import {deepAccess, deepClone, getDNT, generateUUID} from '../src/utils.js';
import {deepAccess, deepClone, getDNT, generateUUID, replaceAuctionPrice} from '../src/utils.js';
import {ajax} from '../src/ajax.js';
import {VIDEO} from '../src/mediaTypes.js';
import {VIDEO, BANNER} from '../src/mediaTypes.js';
import {config} from '../src/config.js';

const BIDDER_CODE = 'alkimi';
Expand Down Expand Up @@ -116,7 +116,7 @@ export const spec = {

// banner or video
if (VIDEO === bid.mediaType) {
bid.vastXml = bid.ad;
bid.vastUrl = replaceAuctionPrice(bid.winUrl, bid.cpm);
}

bid.meta = {};
Expand All @@ -129,21 +129,12 @@ export const spec = {
},

onBidWon: function (bid) {
let winUrl;
if (bid.winUrl || bid.vastUrl) {
winUrl = bid.winUrl ? bid.winUrl : bid.vastUrl;
winUrl = winUrl.replace(/\$\{AUCTION_PRICE}/, bid.cpm);
} else if (bid.ad) {
let trackImg = bid.ad.match(/(?!^)<img src=".+dsp-win.+">/);
bid.ad = bid.ad.replace(trackImg[0], '');
winUrl = trackImg[0].split('"')[1];
winUrl = winUrl.replace(/\$%7BAUCTION_PRICE%7D/, bid.cpm);
} else {
return false;
if (BANNER == bid.mediaType && bid.winUrl) {
const winUrl = replaceAuctionPrice(bid.winUrl, bid.cpm);
ajax(winUrl, null);
return true;
}

ajax(winUrl, null);
return true;
return false;
}
}

Expand Down
6 changes: 3 additions & 3 deletions test/spec/modules/alkimiBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ const BIDDER_VIDEO_RESPONSE = {
'ttl': 200,
'creativeId': 2,
'netRevenue': true,
'winUrl': 'http://test.com',
'winUrl': 'http://test.com?price=${AUCTION_PRICE}',
'mediaType': 'video',
'adomain': ['test.com']
}]
Expand Down Expand Up @@ -195,9 +195,9 @@ describe('alkimiBidAdapter', function () {
expect(result[0]).to.have.property('ttl').equal(200)
expect(result[0]).to.have.property('creativeId').equal(2)
expect(result[0]).to.have.property('netRevenue').equal(true)
expect(result[0]).to.have.property('winUrl').equal('http://test.com')
expect(result[0]).to.have.property('winUrl').equal('http://test.com?price=${AUCTION_PRICE}')
expect(result[0]).to.have.property('mediaType').equal('video')
expect(result[0]).to.have.property('vastXml').equal('<xml>vast</xml>')
expect(result[0]).to.have.property('vastUrl').equal('http://test.com?price=800.4')
expect(result[0].meta).to.exist.property('advertiserDomains')
expect(result[0].meta).to.have.property('advertiserDomains').lengthOf(1)
})
Expand Down