Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imds Bid Adapter : fix incorrectly named user sync property #10562

Merged
merged 4 commits into from
Oct 4, 2023
Merged

imds Bid Adapter : fix incorrectly named user sync property #10562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9a3b10b
imds: Rename usersync from "pixel" to correct name of "image".
ecammit Oct 3, 2023
5271c70
imds: Update documentation for "DFP Video Creative" to match prebid.g…
ecammit Oct 3, 2023
2f119f0
imds: Test modifications for renamed pixel->image usersync
ecammit Oct 3, 2023
e4c44d0
imds: Remove warning for valid no-bid empty body 204 responses.
ecammit Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions modules/imdsBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,6 @@ export const spec = {
};

if (!serverResponse.body || typeof serverResponse.body != 'object') {
logWarn('IMDS: server returned empty/non-json response: ' + JSON.stringify(serverResponse.body));
return;
}
const {id, seatbid: seatbids} = serverResponse.body;
Expand Down Expand Up @@ -324,7 +323,7 @@ export const spec = {
});
} else if (syncOptions.pixelEnabled) {
syncs.push({
type: 'pixel',
type: 'image',
url: `${USER_SYNC_PIXEL_URL}?srv=cs&${queryParams.join('&')}`
});
}
Expand Down
8 changes: 4 additions & 4 deletions modules/imdsBidAdapter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ Maintainer: [email protected]
The iMedia Digital Services adapter requires setup and approval from iMedia Digital Services.
Please reach out to your account manager for more information.

### DFP Video Creative
To use video, setup a `VAST redirect` creative within Google AdManager (DFP) with the following VAST tag URL:
### Google Ad Manager Video Creative
To use video, setup a `VAST redirect` creative within Google Ad Manager with the following VAST tag URL:

```
https://track.technoratimedia.com/openrtb/tags?ID=%%PATTERN:hb_cache_id_synacorm%%&AUCTION_PRICE=%%PATTERN:hb_pb_synacormedia%%
```text
https://track.technoratimedia.com/openrtb/tags?ID=%%PATTERN:hb_uuid_imds%%&AUCTION_PRICE=%%PATTERN:hb_pb_imds%%
```

# Test Parameters
Expand Down
6 changes: 3 additions & 3 deletions test/spec/modules/imdsBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1362,17 +1362,17 @@ describe('imdsBidAdapter ', function () {
expect(usersyncs[0].url).to.contain('https://ad-cdn.technoratimedia.com/html/usersync.html');
});

it('should return a pixel usersync when pixels is enabled', function () {
it('should return an image usersync when pixels are enabled', function () {
let usersyncs = spec.getUserSyncs({
pixelEnabled: true
}, null);
expect(usersyncs).to.be.an('array').with.lengthOf(1);
expect(usersyncs[0]).to.have.property('type', 'pixel');
expect(usersyncs[0]).to.have.property('type', 'image');
expect(usersyncs[0]).to.have.property('url');
expect(usersyncs[0].url).to.contain('https://sync.technoratimedia.com/services');
});

it('should return an iframe usersync when both iframe and pixels is enabled', function () {
it('should return an iframe usersync when both iframe and pixel are enabled', function () {
let usersyncs = spec.getUserSyncs({
iframeEnabled: true,
pixelEnabled: true
Expand Down