DFP Ad Server Video: bugfix - encode description url #10575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmmccann
approved these changes
Oct 5, 2023
patmmccann
added
the
needs 2nd review
ChrisHuie
changed the title
ChrisHuie
approved these changes
Oct 5, 2023
ChrisHuie
removed
the
needs 2nd review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
The DFP module uses the page url as a fallback when populating the
description_urlquery param. If said URL has query params and they are not encoded, the ad tag breaks.The fix consists of calling URI encoding the page url before setting it as a query param.
Other information