Missena Bid Adapter: add capping support #10746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgirardi
reviewed
Nov 22, 2023
modules/missenaBidAdapter.js
Outdated
| @@ -53,6 +56,16 @@ export const spec = { | |||
| * @return ServerRequest Info describing the request to the server. | |||
| */ | |||
| buildRequests: function (validBidRequests, bidderRequest) { | |||
| const capKey = `missena.missena.capper.remove-bubble.${validBidRequests[0]?.params.apiKey}`; | |||
| const capping = JSON.parse(storage.getDataFromLocalStorage(capKey)); | |||
There was a problem hiding this comment.
What sets this in storage - do you have some other script running on the pub page?
If it's not there this will throw an exception, I believe this is why the test run failed. (there's a safeJSONParse you can import from utils.js).
Also, please add some tests for the new logic.
There was a problem hiding this comment.
The storage is set by the renderers we have (when the user is clicking a close button).
I will switch to safeJSONParse and think about a way to test this.
dgirardi
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Some of our publishing partners requested a mechanism to cap the participation in prebid auctions if the user closed our ad. This is particularly relevant in the context of a page that refreshes the ad auctions periodically (e.g. every 15 seconds).
The PR implements the code that checks for the saved capping information and skips the participation if within the capped time frame.