Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NextMillennium Bid Adapter: support for GPP consent string, site.pagecat, site.content.cat and site.content.language #10761

Merged
merged 13 commits into from
Dec 4, 2023

Conversation

mhlm
Copy link
Contributor

@mhlm mhlm commented Nov 25, 2023

Type of change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)

Description of change

  • GPP Consent String support
  • Supplemented test coverage of existing functionality
  • Added support for Openrtb 2.5 parameters: site.pagecat, site.content.cat and site.content.language (Added to the adapter description. PR: OpenRTB 2.5 supported parameters prebid.github.io#4994)
  • Fixed a bug with video ad sizes
  • Rewritten getUserSync function

Other information

@mhlm mhlm changed the title Support for GPP Consent String and Openrtb 2.5 parameters: site.pagecat, site.content.cat and site.content.language NextMillenniumBidAdapter: Support for GPP Consent String and Openrtb 2.5 parameters: site.pagecat, site.content.cat and site.content.language Nov 25, 2023
@ChrisHuie ChrisHuie changed the title NextMillenniumBidAdapter: Support for GPP Consent String and Openrtb 2.5 parameters: site.pagecat, site.content.cat and site.content.language NextMillennium Bid Adapter: support for GPP consent string, site.pagecat, site.content.cat and site.content.language Nov 28, 2023
@ChrisHuie ChrisHuie requested a review from Fawke November 28, 2023 14:26
@Fawke
Copy link
Contributor

Fawke commented Dec 1, 2023

@mhlm You may wanna remove the package-lock.json file from this commit, the rest looks good.

@mhlm
Copy link
Contributor Author

mhlm commented Dec 1, 2023

@Fawke Hi. Removed the package-lock.json file from the changelogs.

Copy link
Contributor

@Fawke Fawke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fawke Fawke merged commit 7be0a10 into prebid:master Dec 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants