lockr AIM user module: initial release #11159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmmccann
reviewed
Mar 8, 2024
patmmccann
requested changes
Mar 8, 2024
|
You may notice you're not passing lint checks as well |
This was caused by us following the documentation and calling "configparams", we have updated this to "config" and it addressed the issue. It was within the lockrAIMIdSystem.js |
|
@jdwieland8282 - can you expand on the "needs docs" label, as all such documentation is included in the "lockrAIMIdSystem.md" file. Thank you. |
|
You need a docs PR against the prebid.github.io repo. This will get your documentation on to prebid.org's website |
|
@KEPlockr you're not passing the linter because you arent following our code style rules
|
patmmccann
reviewed
Mar 27, 2024
patmmccann
reviewed
Mar 27, 2024
patmmccann
reviewed
Mar 27, 2024
| * @returns {lockrAIMId} | ||
| */ | ||
| getId(config, consentData) { | ||
| if (consentData?.gdprApplies === true) { |
There was a problem hiding this comment.
do you want to pass your endpoint the gpp string?
chris-lockr
reviewed
Apr 11, 2024
patmmccann
approved these changes
Apr 16, 2024
patmmccann
changed the title
|
Lgtm You still need to pr https://github.com/prebid/prebid.github.io/pulls?q=is%3Apr+is%3Aopen+lockr it seems? |
2 tasks
Ticki84
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
May 14, 2024
* Adding Lockr AIM module and tests * formatting * Fix formatting * format * fix formatting * add paapi back * added markdown file * 20240324 Fixed Storage Manager | lockrAIMIdSystem.js * Updated to use Prebid Storage Manager | lockrAIMIdSystem_shared.js * added the fix for the comments * removed the unnecessary console --------- Co-authored-by: chris-lockr <[email protected]> Co-authored-by: avin-lockr <[email protected]>
mefjush
pushed a commit
to adhese/Prebid.js
that referenced
this pull request
May 21, 2024
* Adding Lockr AIM module and tests * formatting * Fix formatting * format * fix formatting * add paapi back * added markdown file * 20240324 Fixed Storage Manager | lockrAIMIdSystem.js * Updated to use Prebid Storage Manager | lockrAIMIdSystem_shared.js * added the fix for the comments * removed the unnecessary console --------- Co-authored-by: chris-lockr <[email protected]> Co-authored-by: avin-lockr <[email protected]>
DecayConstant
pushed a commit
to mediavine/Prebid.js
that referenced
this pull request
Jul 18, 2024
* Adding Lockr AIM module and tests * formatting * Fix formatting * format * fix formatting * add paapi back * added markdown file * 20240324 Fixed Storage Manager | lockrAIMIdSystem.js * Updated to use Prebid Storage Manager | lockrAIMIdSystem_shared.js * added the fix for the comments * removed the unnecessary console --------- Co-authored-by: chris-lockr <[email protected]> Co-authored-by: avin-lockr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
The following PR adds the lockr AIM module as a part of prebid.
Alternative Identity Manager (AIM) is a unified container for identity and data management.
With AIM’s self-service platform, publishers seamlessly integrate and activate alternative IDs like LiveRamp’s Authenticated Traffic Solution (ATS), Unified ID 2.0 (UID2), ID5 and more. The burden of due diligence and maintenance, coupled with the benefits of server-side calls result in the adoption of multiple alternative IDs, clean rooms like InfoSum and CDPs like Blueconic based on their specific needs.