JW Player RTD Module : fallback to lone player on page #11186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisHuie
changed the title
karimMourra
force-pushed
the
gro-664-fallback
branch
from
a3fe115
to
5934777
Compare
patmmccann
approved these changes
Jul 3, 2024
DecayConstant
pushed a commit
to mediavine/Prebid.js
that referenced
this pull request
Jul 18, 2024
* fallsback * improves error messaging * updates div id name * adds tests
mefjush
pushed a commit
to adhese/Prebid.js
that referenced
this pull request
Jul 19, 2024
* fallsback * improves error messaging * updates div id name * adds tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This is a convenience for Publishers using the wrong Player Div Id.
When there is only 1 instance of a JW Player on the page, the module picks that player instance for targeting and logs a warning.
If multiple players are on the page, and none match the Player Div Id, then none are used.