Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anyclip Bid Adapter : initial release #11200

Merged
merged 5 commits into from
Apr 4, 2024
Merged

Anyclip Bid Adapter : initial release #11200

merged 5 commits into from
Apr 4, 2024

Conversation

basil79
Copy link
Contributor

@basil79 basil79 commented Mar 13, 2024 •
edited
Loading

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Added new bid adapter AnyClip. It uses the external PubTag library for fast bids, first please add the following file to the <HEAD>

<!-- AnyClip PubTag -->
<script src="https://anyclip-player.s3.amazonaws.com/anyclip-widget/pubtag/pubtag.js"></script>
var adUnits = [{
    code: 'adunit1',
    mediaTypes: {
        banner: { // support banner only
            sizes: [
                [300, 250]
            ]
        }
    },
    bids: [{
        bidder: 'anyclip',
        params: {
            publisherId: '12345', // required, string
            supplyTagId: '-mptNo0BycUG4oCDgGrU', // required, string
            floor: 0.1 // optional, floor
        }
    }]
}]

Be sure to test the integration with your adserver using the Hello World sample page. -->

Other information

@basil79 basil79 mentioned this pull request Mar 13, 2024
Merged
8 tasks
@ChrisHuie ChrisHuie changed the title Anyclip bid adapter Anyclip Bid Adapter : initial release Mar 14, 2024
@Rothalack
Copy link
Collaborator

For your external PubTag code. I think the only other bidder doing something like this is Criteo and they seem to have gotten worked out where you do not need to ask the user to include an extra script in the head. I think you should attempt to do it that way, having the user have to add an extra script isn't an intended way of doing it. You should be able to see it here
https://github.com/criteo-forks/Prebid.js/blob/master/modules/criteoBidAdapter.js

Feel free to push back, I'm not absolutely certain about this.

@basil79
Copy link
Contributor Author

basil79 commented Mar 18, 2024 •
edited
Loading

For your external PubTag code. I think the only other bidder doing something like this is Criteo and they seem to have gotten worked out where you do not need to ask the user to include an extra script in the head. I think you should attempt to do it that way, having the user have to add an extra script isn't an intended way of doing it. You should be able to see it here https://github.com/criteo-forks/Prebid.js/blob/master/modules/criteoBidAdapter.js

Feel free to push back, I'm not absolutely certain about this.

@Rothalack, yes, you right, it is similar to the Criteo adapter, but Criteo uses loadExternalScript from '../src/adloader.js', -> https://github.com/criteo-forks/Prebid.js/blob/master/src/adloader.js#L6, which requires a code review for the external file to allow our adapter to use this feature.

https://github.com/criteo-forks/Prebid.js/blob/master/modules/criteoBidAdapter.js#L186

This is normal for us: all of our publishers must include our PubTag library in order to use our prebid adapter.

@patmmccann
Copy link
Collaborator

Hi @basil79 ; criteo is in process of removing this dependency in prebid 9

@basil79
Copy link
Contributor Author

basil79 commented Mar 20, 2024

Hi @basil79 ; criteo is in process of removing this dependency in prebid 9

Hi @patmmccann , give me their pr I will check

@basil79
Copy link
Contributor Author

basil79 commented Mar 27, 2024

@Rothalack, any updates?

@Rothalack
Copy link
Collaborator

There is a divide in opinion on whether or not the way you're doing this should be allowed. I've voiced my thoughts on this. I do not feel like I'm in the position to make this decision, it's a policy decision.

I'm unsure if @patmmccann s comment here was a request for you to make a change or just information for you.

@basil79
Copy link
Contributor Author

basil79 commented Mar 27, 2024

There is a divide in opinion on whether or not the way you're doing this should be allowed. I've voiced my thoughts on this. I do not feel like I'm in the position to make this decision, it's a policy decision.

I'm unsure if @patmmccann s comment here was a request for you to make a change or just information for you.

@Rothalack , criteo has been using this method for many years, we want to use it too. I haven't found any policies or restrictions to not do it this way.

@Rothalack
Copy link
Collaborator

They're doing it the intended way, which is to have the external JS in an open source github repo under Prebid. My understanding at least is that this is to keep the spirit of open source and have the code be publicly accountable.

@basil79
Copy link
Contributor Author

basil79 commented Mar 27, 2024

They're doing it the intended way, which is to have the external JS in an open source github repo under Prebid. My understanding at least is that this is to keep the spirit of open source and have the code be publicly accountable.

but we don't load external JS file using Prebid, our publishers do that

@Rothalack
Copy link
Collaborator

Right, which is where the divide in opinion occurs.

@basil79
Copy link
Contributor Author

basil79 commented Mar 27, 2024

bottom line, any publisher wishing to use any prebid adapter must contact the company (ex SSP provider) that owns the adapter to obtain connection params etc.

Rothalack
Rothalack approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@Rothalack Rothalack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to go ahead and approve and merge this. I don't see any more discussion on this topic and it seems like Pat was in approval.

@Rothalack Rothalack merged commit 0bcd57f into prebid:master Apr 4, 2024
4 checks passed
mefjush pushed a commit to adhese/Prebid.js that referenced this pull request Apr 8, 2024
@basil79 @mefjush
Anyclip Bid Adapter : initial release (prebid#11200)
55a3a17 
* prepare anyclipBidAdapter

* added spec test for anyclipBidAdapter

* cleanup

* fixed readme

* added getFloor support

---------

Co-authored-by: Basil Goldman <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rothalack Rothalack Rothalack approved these changes

Assignees

@Rothalack Rothalack

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@basil79 @Rothalack @patmmccann @ChrisHuie