PubxAi Analytics Adapter : code cleanup and additional data collection

[pnhegde]

Type of change

• Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Does this change affect user-facing APIs or examples documented on http://prebid.org?
• Other

Description of change

Code cleanup and refactoring, renaming of fields, and additional data collection as part of analytics.

[pnhegde]

@ChrisHuie All the tests have passed already. Anything else needed from our end? Thanks.

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/pubxaiAnalyticsAdapter.js has 12 duplicated lines with modules/terceptAnalyticsAdapter.js
• modules/pubxaiAnalyticsAdapter.js has 11 duplicated lines with modules/roxotAnalyticsAdapter.js
• modules/mediakeysBidAdapter.js has 18 duplicated lines with modules/pubxaiAnalyticsAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/pubxaiAnalyticsAdapter.js has 12 duplicated lines with modules/terceptAnalyticsAdapter.js
• modules/pubxaiAnalyticsAdapter.js has 11 duplicated lines with modules/roxotAnalyticsAdapter.js
• modules/mediakeysBidAdapter.js has 18 duplicated lines with modules/pubxaiAnalyticsAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

[pnhegde]

@ncolletti @patmmccann I'm not sure what to do to avoid duplication error here. I don't think we can import code from other analytics adapters or if we can move them to a common library.

Also, we have fixed the storage issue but sendBeacon is kept as it is instead of switching to fetch-keepalive due to a firefox compatibility issue. Let me know if this works or anything else we need to do.

Thanks!

[patmmccann]

Please move into a common library, eg this appears to be a direct copy, not sure of which direction, but both modules could easily import from a common place in the libraries folder:

"format": "javascript",
"lines": 18,
"fragment": "function getOS() {\n if (navigator.userAgent.indexOf('Android') != -1) return 'Android';\n if (navigator.userAgent.indexOf('like Mac') != -1) return 'iOS';\n if (navigator.userAgent.indexOf('Win') != -1) return 'Windows';\n if (navigator.userAgent.indexOf('Mac') != -1) return 'Macintosh';\n if (navigator.userAgent.indexOf('Linux') != -1) return 'Linux';\n if (navigator.appVersion.indexOf('X11') != -1) return 'Unix';\n return 'Others';\n}\n\n/**\n * Returns floor from priceFloors module or MediaKey default value.\n \n * @param {} bid a Prebid.js bid (request) object\n * @param {string} mediaType the mediaType or the wildcard ''\n * @param {string|Array} size the size array or the wildcard ''\n * @returns {number|boolean}\n */",