Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PubMatic Bid Adapter : start sending displaymanager & displaymanagerver #11530

Merged
merged 4 commits into from
May 22, 2024
Merged

PubMatic Bid Adapter : start sending displaymanager & displaymanagerver #11530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6f0d0a3
Added support for displaymanager & version to pubmatic adapter
kapil-tuptewar May 16, 2024
36f9fd1
Merge branch 'master' into UOE-10529
kapil-tuptewar May 20, 2024
48a73ec
Merge branch 'master' into UOE-10529
kapil-tuptewar May 21, 2024
6b2816c
Added comments
kapil-tuptewar May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion modules/pubmaticBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,7 +673,9 @@ function _createImpressionObject(bid, bidderRequest) {
ext: {
pmZoneId: _parseSlotParam('pmzoneid', bid.params.pmzoneid)
},
bidfloorcur: bid.params.currency ? _parseSlotParam('currency', bid.params.currency) : DEFAULT_CURRENCY
bidfloorcur: bid.params.currency ? _parseSlotParam('currency', bid.params.currency) : DEFAULT_CURRENCY,
displaymanager: 'Prebid.js',
displaymanagerver: '$prebid.version$' // prebid version
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not put this on ext so it remains valid ortb?

Copy link
Contributor Author

@kapil-tuptewar kapil-tuptewar May 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patmmccann I can see these fields are present in root object in ORTB - 2.5 as well as 2.6 spec, so I placed at same order.
ortb_ss

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow, i was unfamiliar with them

};

_addPMPDealsInImpression(impObj, bid);
Expand Down
2 changes: 2 additions & 0 deletions test/spec/modules/pubmaticBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1187,6 +1187,8 @@ describe('PubMatic adapter', function () {
expect(data.imp[0].bidfloorcur).to.equal(bidRequests[0].params.currency);
expect(data.source.ext.schain).to.deep.equal(bidRequests[0].schain);
expect(data.ext.epoch).to.exist;
expect(data.imp[0].displaymanager).to.equal('Prebid.js');
expect(data.imp[0].displaymanagerver).to.equal('$prebid.version$');
});

it('Set tmax from global config if not set by requestBids method', function() {
Expand Down