Triplelift: Adding support for video.plcmt #11554
Conversation
modules/tripleliftBidAdapter.js
Outdated
| @@ -241,6 +241,9 @@ function _getORTBVideo(bidRequest) { | |||
| if (!video.placement) { | |||
| video.placement = 1; | |||
| } | |||
| if (!video.plcmt) { | |||
| video.plcmt = 1; | |||
There was a problem hiding this comment.
@fowler446 can you comment here? Generally video.context instream does not map to plcmt = 1
There was a problem hiding this comment.
This is direct from IAB so I think we have instream plcmt correct. But like I mentioned below, if the publisher sets this, we don't meddle with it.
There was a problem hiding this comment.
You're gonna get in trouble here from ttd. They were very adamant no one does this. Prebid instream context basically just means preroll, there is no easy way for you to infer if plcmt should be 1 or 2
modules/tripleliftBidAdapter.js
Outdated
| @@ -249,6 +252,9 @@ function _getORTBVideo(bidRequest) { | |||
| logMessage(`video.placement value of ${video.placement} is invalid for outstream context. Setting placement to 3`) | |||
| video.placement = 3 | |||
| } | |||
| if (!video.plcmt) { | |||
| video.plcmt = 4; | |||
There was a problem hiding this comment.
prebid already has logic in place doing something similar
There was a problem hiding this comment.
to support plcmt, pick up what you find in the request, this logic to infer it is not necessary. That's true for the old value as well.
There was a problem hiding this comment.
in current versions? or in the upcoming v9? Because currently if video.placement isn't set, it will not be added to the bid request
There was a problem hiding this comment.
Thanks for the info, I reviewed it. After reviewing the logic in src/video.js, it seems like our logic is slightly redundant for outstream but not for instream and not for legacy placement values (which triplelift still wants to ingest).
Both checks in our adapter are secondary checks and are irrelevant if the publisher does the right thing:
https://github.com/prebid/Prebid.js/blob/master/modules/tripleliftBidAdapter.js#L232
We just want to ensure that we are still receiving both new and legacy placement values if not set by the publisher which I understand is covered in video.js but only for the outstream plcmt value scenario.
Type of change
Description of change
Adding support for
video.plcmtif the publisher doesn't explicitly set it