Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concert Bid Adapter : add dealId Property to Bid Responses #11582

Merged
merged 26 commits into from
May 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
a0bfc6b
collect EIDs for bid request
antoinfive Sep 26, 2022
d4392ca
Merge pull request #5 from voxmedia/ac-add-uid2
antoinfive Oct 17, 2022
0be448c
add ad slot positioning to payload
antoinfive Sep 27, 2022
653989d
Merge pull request #6 from voxmedia/ac-add-xy-offset-for-ad-slot
antoinfive Oct 17, 2022
83fdbd8
Merge branch 'prebid:master' into master
antoinfive Oct 17, 2022
b47f73a
Merge branch 'prebid:master' into master
BrettBlox Oct 18, 2022
a692b6c
Merge branch 'prebid:master' into master
BrettBlox Oct 27, 2022
c54b011
RPO-2012: Update local storage name-spacing for c_uid (#8)
BrettBlox Oct 27, 2022
2bb7143
RPO-2012: Add check for shared id (#9)
BrettBlox Nov 4, 2022
d38d7fd
Merge branch 'prebid:master' into master
BrettBlox Nov 10, 2022
572526e
Merge branch 'prebid:master' into master
BrettBlox Feb 8, 2023
7c1969c
Merge branch 'prebid:master' into master
BrettBlox Mar 20, 2023
99b0664
[RPO-3152] Enable Support for GPP Consent (#12)
BrettBlox Mar 22, 2023
105802d
fixes conditional logic for consent allows function (#13)
BrettBlox Mar 22, 2023
4a43497
Merge branch 'prebid:master' into master
BrettBlox Mar 28, 2023
a0d3f83
Merge branch 'prebid:master' into master
BrettBlox Apr 6, 2023
0ee3b28
[RPO-3262] Update getUid function to check for pubcid and sharedid (#14)
BrettBlox Apr 6, 2023
d46d102
[RPO-3405] Add browserLanguage to request meta object
Skitelman Aug 10, 2023
c4fdab6
Merge pull request #15 from voxmedia/RPO-3405-add-browser-language
Skitelman Aug 14, 2023
afde14d
Merge branch 'prebid:master' into master
Skitelman Aug 14, 2023
5af088b
Merge remote-tracking branch 'upstream/master'
Skitelman Sep 25, 2023
aa9f8b0
ConcertBidAdapter: Add TDID (#20)
Skitelman Sep 28, 2023
4792031
Merge remote-tracking branch 'upstream/master'
Skitelman Oct 2, 2023
012bfbf
Merge branch 'prebid:master' into master
BrettBlox Apr 10, 2024
c13d1e1
Merge branch 'prebid:master' into master
Skitelman May 21, 2024
e197133
Concert Bid Adapter: Add dealId Property to Bid Responses (#22)
BrettBlox May 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/concertBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,8 @@ export const spec = {
meta: { advertiserDomains: bid && bid.adomain ? bid.adomain : [] },
creativeId: bid.creativeId,
netRevenue: bid.netRevenue,
currency: bid.currency
currency: bid.currency,
...(bid.dealid && { dealId: bid.dealid }),
};
});

Expand Down
16 changes: 16 additions & 0 deletions test/spec/modules/concertBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,22 @@ describe('ConcertAdapter', function () {
});
});

it('should include dealId when present in bidResponse', function() {
const bids = spec.interpretResponse({
body: {
bids: [
{ ...bidResponse.body.bids[0], dealid: 'CON-123' }
]
}
}, bidRequest);
expect(bids[0]).to.have.property('dealId');
});

it('should exclude dealId when absent in bidResponse', function() {
const bids = spec.interpretResponse(bidResponse, bidRequest);
expect(bids[0]).to.not.have.property('dealId');
});

it('should return empty bids if there is no response from server', function() {
const bids = spec.interpretResponse({ body: null }, bidRequest);
expect(bids).to.have.lengthOf(0);
Expand Down