AdHash Bid Adapter: brand safety changes #11617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're operating on a com TLD now. Added publisher in URL for easier routing.
Implemented brand safety checks
Removing the extra information as request data becomes too big and is sometimes truncated
Ad fraud prevention formula changed to support negative values as well as linear distribution of article length
Adding starts-with and ends-with rules that will help us with languages such as German where a single word can be written in multiple ways depending on the gender and grammatical case.
Added support for Cyrillic characters. Added support for bidderURL parameter. Fixed score multiplier from 500 to 1000.
Support for recent ads which gives us the option to do frequency and recency capping.
Added unit tests for the analytics adapter
Removed an unneeded export of a const that was causing errors with the analytics adapter
Adding support for compound words as well as combo-patterns.
* Adding the options to read and write recent ads from the local storage when enabled. * Using outerText for whole page text selection.
|
@wyand-sp this test failure should be fixed in the latest version of master if you want to pull in recent commits |
patmmccann
reviewed
May 30, 2024
modules/adhashBidAdapter.js
Outdated
| @@ -120,7 +121,7 @@ function brandSafety(badWords, maxScore) { | |||
| .replaceAll(/\s\s+/g, ' ') | |||
| .toLowerCase() | |||
| .trim(); | |||
| const content = window.top.document.body.innerText.toLowerCase(); | |||
| const content = window.top.document.body.outerText.toLowerCase(); | |||
There was a problem hiding this comment.
does textContent not work? that's what we used in 9.0 branch
There was a problem hiding this comment.
https://kellegous.com/j/2013/01/26/layout-performance/ outerText just as bad
There was a problem hiding this comment.
Understood. We've updated the code. Thanks for your comment.
Using textContent to get the raw text from the body.
jsnellbaker
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the recent ads calculations to the latest supported version.
Removed the usage of body.innerText
Type of change
Description of change
Changing the recent ads calculations to the latest supported version.
Removed the usage of body.innerText as needed in Prebid JS 9.0