Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdvRed Analytics Adapter : initial release #11703

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

danoykin
Copy link
Contributor

@danoykin danoykin commented Jun 5, 2024

  • New analytics adapter

Maintainer: [email protected]

pbjs.enableAnalytics({
provider: 'advRed',
options: {
publisherId: '123456'
}
});

@ChrisHuie ChrisHuie changed the title AdvRed analytics adapter AdvRed Analytics Adapter : initial release Jun 7, 2024
Copy link
Contributor

@spotxslagle spotxslagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you only send events if the auction completes. It looks like this is intended, but you will be missing out on a lot of events from auctions that don't complete. Assuming you're fine with that, the rest looks good to me.

@patmmccann
Copy link
Collaborator

@danoykin are you okay with that? Can you link the docs pr?

@danoykin
Copy link
Contributor Author

danoykin commented Jul 2, 2024

@patmmccann @spotxslagle Yes, it is ok. We are going to count only completed auctions for the current version.

@patmmccann patmmccann merged commit 4343dda into prebid:master Jul 10, 2024
4 checks passed
DecayConstant pushed a commit to mediavine/Prebid.js that referenced this pull request Jul 18, 2024
* Initial version of AdvRed analytics adapter

* Initial version of AdvRed analytics adapter
mefjush pushed a commit to adhese/Prebid.js that referenced this pull request Jul 19, 2024
* Initial version of AdvRed analytics adapter

* Initial version of AdvRed analytics adapter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants