Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9.0: 10452 enforce, need plcmt to get placement #11718

Merged
merged 64 commits into from
Jun 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
64 commits
Select commit Hold shift + click to select a range
027759b
Update adbookpspBidAdapter.js
patmmccann Jun 5, 2024
a9c469e
Update admanBidAdapter.js
patmmccann Jun 5, 2024
42cb977
Update adtrueBidAdapter.js
patmmccann Jun 6, 2024
abe9c5e
Update appushBidAdapter.js
patmmccann Jun 6, 2024
8b4aaac
Update axisBidAdapter.js
patmmccann Jun 6, 2024
1ea63e4
Update beyondmediaBidAdapter.js
patmmccann Jun 6, 2024
37f3ec4
Update boldwinBidAdapter.js
patmmccann Jun 6, 2024
c514e87
Update dspxBidAdapter.js
patmmccann Jun 6, 2024
62a854b
Update edge226BidAdapter.js
patmmccann Jun 6, 2024
2c22c69
Update emtvBidAdapter.js
patmmccann Jun 6, 2024
bb3f936
Update globalsunBidAdapter.js
patmmccann Jun 6, 2024
d81adb4
Update gothamadsBidAdapter.js
patmmccann Jun 6, 2024
11e30b7
Update precisoBidAdapter.js
patmmccann Jun 6, 2024
ebf8d2d
Update smartyadsBidAdapter.js
patmmccann Jun 6, 2024
d0e2c8a
Update gothamadsBidAdapter.js
patmmccann Jun 6, 2024
981d1c7
Update precisoBidAdapter.js
patmmccann Jun 6, 2024
e9195fe
Update gothamadsBidAdapter.js
patmmccann Jun 6, 2024
f0aef23
Update lkqdBidAdapter.js
patmmccann Jun 6, 2024
d06c637
Delete modules/iqmBidAdapter.js
patmmccann Jun 6, 2024
afdb748
Delete test/spec/modules/iqmBidAdapter_spec.js
patmmccann Jun 6, 2024
1e7c2f6
Update smartyadsBidAdapter.js
patmmccann Jun 6, 2024
b9efaf1
Update kiviadsBidAdapter.js
patmmccann Jun 6, 2024
0616581
Update krushmediaBidAdapter.js
patmmccann Jun 6, 2024
7f1991a
Update kueezBidAdapter.js
patmmccann Jun 6, 2024
d271849
Update loganBidAdapter.js
patmmccann Jun 6, 2024
c2bf396
Update loyalBidAdapter.js
patmmccann Jun 6, 2024
99c155e
Update mediakeysBidAdapter.js
patmmccann Jun 6, 2024
445f760
Update mgidXBidAdapter.js
patmmccann Jun 6, 2024
b7574bf
Update mobfoxpbBidAdapter.js
patmmccann Jun 6, 2024
e886287
Update operaadsBidAdapter.js
patmmccann Jun 6, 2024
4754933
Update pgamsspBidAdapter.js
patmmccann Jun 6, 2024
5c02b6e
Update pstudioBidAdapter.js
patmmccann Jun 6, 2024
f719544
Update pubgeniusBidAdapter.js
patmmccann Jun 6, 2024
4273bb1
Update pubCircleBidAdapter.js
patmmccann Jun 6, 2024
766efe3
Update shinezBidAdapter.js
patmmccann Jun 6, 2024
c135241
Update videobyteBidAdapter.js
patmmccann Jun 6, 2024
497dc31
Update visiblemeasuresBidAdapter.js
patmmccann Jun 6, 2024
f5f00ab
Update waardexBidAdapter.js
patmmccann Jun 6, 2024
dba62aa
Update 33acrossBidAdapter.js
patmmccann Jun 6, 2024
c4b27e3
Update gothamadsBidAdapter.js
patmmccann Jun 6, 2024
7b77d24
Update gothamadsBidAdapter.js
patmmccann Jun 6, 2024
7ee6908
Update precisoBidAdapter.js
patmmccann Jun 6, 2024
2a2f458
Update smartyadsBidAdapter.js
patmmccann Jun 6, 2024
8441fbb
Update smartxBidAdapter.js
patmmccann Jun 6, 2024
78b358e
Update ozoneBidAdapter.js
patmmccann Jun 6, 2024
1cd9442
Update smartxBidAdapter.js
patmmccann Jun 6, 2024
990a3f7
Update 33acrossBidAdapter_spec.js
patmmccann Jun 6, 2024
4990996
Update admanBidAdapter_spec.js
patmmccann Jun 6, 2024
3fe8835
Update krushmediaBidAdapter_spec.js
patmmccann Jun 6, 2024
ad1d5b9
Update loganBidAdapter_spec.js
patmmccann Jun 6, 2024
a235227
Update mobfoxpbBidAdapter_spec.js
patmmccann Jun 6, 2024
1b5606f
Update precisoBidAdapter.js
patmmccann Jun 6, 2024
43608d9
Update smartyadsBidAdapter.js
patmmccann Jun 6, 2024
f554903
Update e_volutionBidAdapter.js
patmmccann Jun 6, 2024
7d4a665
Update e_volutionBidAdapter.js
patmmccann Jun 6, 2024
6950556
Update pubmaticBidAdapter.js
patmmccann Jun 6, 2024
5e723ef
Update iqzoneBidAdapter.js
patmmccann Jun 6, 2024
f06e53a
Update qtBidAdapter.js
patmmccann Jun 6, 2024
9a23da3
Update lunamediahbBidAdapter.js
patmmccann Jun 6, 2024
fd75f20
Update krushmediaBidAdapter.js
patmmccann Jun 6, 2024
758c018
Update pubgeniusBidAdapter_spec.js
patmmccann Jun 6, 2024
adc93aa
Update smartxBidAdapter_spec.js
patmmccann Jun 6, 2024
53bd602
Update apacdexBidAdapter_spec.js
patmmccann Jun 6, 2024
cf4a0ff
Update apacdexBidAdapter_spec.js
patmmccann Jun 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions modules/33acrossBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,6 @@ function _buildVideoORTB(bidRequest) {
// Placement Inference Rules:
// - If no placement is defined then default to 2 (In Banner)
// - If the old deprecated field is defined, use its value for the recent placement field
// - If product is instream (for instream context) then override placement to 1

const calculatePlacementValue = () => {
const IN_BANNER_PLACEMENT_VALUE = 2;
Expand All @@ -510,8 +509,6 @@ function _buildVideoORTB(bidRequest) {

if (product === PRODUCT.INSTREAM) {
video.startdelay = video.startdelay || 0;
video.plcmt = 1;
video.placement &&= 1;
}

// bidfloors
Expand Down
1 change: 1 addition & 0 deletions modules/adbookpspBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ const VIDEO_PARAMS = [
'h',
'startdelay',
'placement',
'plcmt',
'linearity',
'skip',
'skipmin',
Expand Down
1 change: 1 addition & 0 deletions modules/admanBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ export const spec = {
placement.protocols = mediaTypes[VIDEO].protocols;
placement.startdelay = mediaTypes[VIDEO].startdelay;
placement.placement = mediaTypes[VIDEO].placement;
placement.plcmt = mediaTypes[VIDEO].plcmt;
placement.skip = mediaTypes[VIDEO].skip;
placement.skipafter = mediaTypes[VIDEO].skipafter;
placement.minbitrate = mediaTypes[VIDEO].minbitrate;
Expand Down
1 change: 1 addition & 0 deletions modules/adtrueBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ const VIDEO_CUSTOM_PARAMS = {
'battr': DATA_TYPES.ARRAY,
'linearity': DATA_TYPES.NUMBER,
'placement': DATA_TYPES.NUMBER,
'plcmt': DATA_TYPES.NUMBER,
'minbitrate': DATA_TYPES.NUMBER,
'maxbitrate': DATA_TYPES.NUMBER
};
Expand Down
1 change: 1 addition & 0 deletions modules/appushBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ function getPlacementReqData(bid) {
placement.protocols = mediaTypes[VIDEO].protocols;
placement.startdelay = mediaTypes[VIDEO].startdelay;
placement.placement = mediaTypes[VIDEO].placement;
placement.plcmt = mediaTypes[VIDEO].plcmt;
placement.skip = mediaTypes[VIDEO].skip;
placement.skipafter = mediaTypes[VIDEO].skipafter;
placement.minbitrate = mediaTypes[VIDEO].minbitrate;
Expand Down
1 change: 1 addition & 0 deletions modules/axisBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ function getPlacementReqData(bid) {
placement.mimes = mediaTypes[VIDEO].mimes;
placement.protocols = mediaTypes[VIDEO].protocols;
placement.startdelay = mediaTypes[VIDEO].startdelay;
placement.plcmt = mediaTypes[VIDEO].plcmt;
placement.placement = mediaTypes[VIDEO].placement;
placement.skip = mediaTypes[VIDEO].skip;
placement.skipafter = mediaTypes[VIDEO].skipafter;
Expand Down
1 change: 1 addition & 0 deletions modules/beyondmediaBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ function getPlacementReqData(bid) {
placement.protocols = mediaTypes[VIDEO].protocols;
placement.startdelay = mediaTypes[VIDEO].startdelay;
placement.placement = mediaTypes[VIDEO].placement;
placement.plcmt = mediaTypes[VIDEO].plcmt;
placement.skip = mediaTypes[VIDEO].skip;
placement.skipafter = mediaTypes[VIDEO].skipafter;
placement.minbitrate = mediaTypes[VIDEO].minbitrate;
Expand Down
1 change: 1 addition & 0 deletions modules/boldwinBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ export const spec = {
placement.protocols = mediaTypes[VIDEO].protocols;
placement.startdelay = mediaTypes[VIDEO].startdelay;
placement.placement = mediaTypes[VIDEO].placement;
placement.plcmt = mediaTypes[VIDEO].plcmt;
placement.skip = mediaTypes[VIDEO].skip;
placement.skipafter = mediaTypes[VIDEO].skipafter;
placement.minbitrate = mediaTypes[VIDEO].minbitrate;
Expand Down
2 changes: 1 addition & 1 deletion modules/dspxBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const BIDDER_CODE = 'dspx';
const ENDPOINT_URL = 'https://buyer.dspx.tv/request/';
const ENDPOINT_URL_DEV = 'https://dcbuyer.dspx.tv/request/';
const GVLID = 602;
const VIDEO_ORTB_PARAMS = ['mimes', 'minduration', 'maxduration', 'protocols', 'w', 'h', 'startdelay', 'placement', 'linearity', 'skip', 'skipmin',
const VIDEO_ORTB_PARAMS = ['mimes', 'minduration', 'maxduration', 'protocols', 'w', 'h', 'startdelay', 'placement', 'plcmt', 'linearity', 'skip', 'skipmin',
'skipafter', 'sequence', 'battr', 'maxextended', 'minbitrate', 'maxbitrate', 'boxingallowed', 'playbackmethod', 'playbackend', 'delivery', 'pos', 'companionad',
'api', 'companiontype', 'ext'];

Expand Down
3 changes: 1 addition & 2 deletions modules/e_volutionBidAdapter.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { registerBidder } from '../src/adapters/bidderFactory.js';
import { BANNER, NATIVE, VIDEO } from '../src/mediaTypes.js';
import { deepAccess, logMessage, logError } from '../src/utils.js';
import { deepAccess, logMessage } from '../src/utils.js';
import { convertOrtbRequestToProprietaryNative } from '../src/native.js';

const BIDDER_CODE = 'e_volution';
Expand Down Expand Up @@ -83,7 +83,6 @@ function getBidFloor(bid) {
});
return bidFloor.floor;
} catch (err) {
logError(err);
return 0;
}
}
Expand Down
1 change: 1 addition & 0 deletions modules/edge226BidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ function getPlacementReqData(bid) {
placement.protocols = mediaTypes[VIDEO].protocols;
placement.startdelay = mediaTypes[VIDEO].startdelay;
placement.placement = mediaTypes[VIDEO].placement;
placement.plcmt = mediaTypes[VIDEO].plcmt;
placement.skip = mediaTypes[VIDEO].skip;
placement.skipafter = mediaTypes[VIDEO].skipafter;
placement.minbitrate = mediaTypes[VIDEO].minbitrate;
Expand Down
1 change: 1 addition & 0 deletions modules/emtvBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ function getPlacementReqData(bid) {
placement.protocols = mediaTypes[VIDEO].protocols;
placement.startdelay = mediaTypes[VIDEO].startdelay;
placement.placement = mediaTypes[VIDEO].placement;
placement.plcmt = mediaTypes[VIDEO].plcmt;
placement.skip = mediaTypes[VIDEO].skip;
placement.skipafter = mediaTypes[VIDEO].skipafter;
placement.minbitrate = mediaTypes[VIDEO].minbitrate;
Expand Down
1 change: 1 addition & 0 deletions modules/globalsunBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ function getPlacementReqData(bid) {
placement.protocols = mediaTypes[VIDEO].protocols;
placement.startdelay = mediaTypes[VIDEO].startdelay;
placement.placement = mediaTypes[VIDEO].placement;
placement.plcmt = mediaTypes[VIDEO].plcmt;
placement.skip = mediaTypes[VIDEO].skip;
placement.skipafter = mediaTypes[VIDEO].skipafter;
placement.minbitrate = mediaTypes[VIDEO].minbitrate;
Expand Down
19 changes: 5 additions & 14 deletions modules/gothamadsBidAdapter.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { logMessage, deepSetValue, deepAccess, _map, logWarn } from '../src/utils.js';
import { deepSetValue, deepAccess, _map, logWarn } from '../src/utils.js';
import { registerBidder } from '../src/adapters/bidderFactory.js';
import { BANNER, NATIVE, VIDEO } from '../src/mediaTypes.js';
import { config } from '../src/config.js';
Expand Down Expand Up @@ -80,18 +80,9 @@ export const spec = {
if (validBidRequests && validBidRequests.length === 0) return []
let accuontId = validBidRequests[0].params.accountId;
const endpointURL = URL_ENDPOINT.replace(ACCOUNTID_MACROS, accuontId);

let winTop = window;
let location;
// TODO: this odd try-catch block was copied in several adapters; it doesn't seem to be correct for cross-origin
try {
location = new URL(bidderRequest.refererInfo.page)
winTop = window.top;
} catch (e) {
location = winTop.location;
logMessage(e);
};

location = bidderRequest?.refererInfo ?? null;
let bids = [];
for (let bidRequest of validBidRequests) {
let impObject = prepareImpObject(bidRequest);
Expand All @@ -105,8 +96,8 @@ export const spec = {
language: (navigator && navigator.language) ? navigator.language.indexOf('-') != -1 ? navigator.language.split('-')[0] : navigator.language : '',
},
site: {
page: location.pathname,
host: location.host
page: location?.page,
host: location?.domain
},
source: {
tid: bidderRequest?.ortb2?.source?.tid,
Expand Down Expand Up @@ -332,7 +323,7 @@ const parseSizes = (bid, mediaType) => {

const addVideoParameters = (bidRequest) => {
let videoObj = {};
let supportParamsList = ['mimes', 'minduration', 'maxduration', 'protocols', 'startdelay', 'placement', 'skip', 'skipafter', 'minbitrate', 'maxbitrate', 'delivery', 'playbackmethod', 'api', 'linearity']
let supportParamsList = ['mimes', 'minduration', 'maxduration', 'protocols', 'startdelay', 'skip', 'skipafter', 'minbitrate', 'maxbitrate', 'delivery', 'playbackmethod', 'api', 'linearity']

for (let param of supportParamsList) {
if (bidRequest.mediaTypes.video[param] !== undefined) {
Expand Down
Loading