Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github action: Update jscpd.yml to comment with code duplication results #11742

Merged
merged 16 commits into from
Jun 9, 2024

Conversation

patmmccann
Copy link
Collaborator

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

Copy link

github-actions bot commented Jun 9, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

  • modules/33acrossBidAdapter.js has 13 duplicated lines with modules/iqmBidAdapter.js
  • modules/33acrossBidAdapter.js has 14 duplicated lines with modules/underdogmediaBidAdapter.js
  • modules/33acrossBidAdapter.js has 79 duplicated lines with modules/onomagicBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Keep up the great work! 🚀

@patmmccann
Copy link
Collaborator Author

fixes #11740

@patmmccann patmmccann linked an issue Jun 9, 2024 that may be closed by this pull request
@patmmccann patmmccann merged commit 990e4e8 into master Jun 9, 2024
3 of 4 checks passed
@patmmccann patmmccann deleted the patmmccann-patch-9 branch June 9, 2024 19:32
@patmmccann patmmccann changed the title Update jscpd.yml Github action: Update jscpd.yml to comment with code duplication results Jun 9, 2024
@patmmccann patmmccann self-assigned this Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub actions: improve code duplicatuon output
1 participant