Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relaido Bid Adapter : add placementId to renderAd parameters #11769

Merged
merged 31 commits into from
Jun 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
1d0240f
add relaido adapter
r-ishigami Apr 9, 2020
9be8275
remove event listener
r-ishigami Apr 9, 2020
d63a27a
fixed UserSyncs and e.data
r-ishigami Apr 10, 2020
8c7f8a0
fix conflicts
r-ishigami May 20, 2020
6cb31b6
fix conflicts
r-ishigami May 20, 2020
114d6d2
Merge remote-tracking branch 'root_branch/master'
r-ishigami Jul 6, 2020
e0092cc
Merge remote-tracking branch 'root_branch/master' into master
Oct 9, 2020
dd0b7d7
Merge remote-tracking branch 'root_branch/master'
Oct 29, 2020
975f838
Merge remote-tracking branch 'root_branch/master'
Nov 18, 2020
0040be7
Merge remote-tracking branch 'root_branch/master'
May 17, 2021
5e086c4
Merge remote-tracking branch 'root_branch/master'
Jun 2, 2021
0572f86
Merge remote-tracking branch 'root_branch/master'
Jun 2, 2021
56da7ec
Merge remote-tracking branch 'root_branch/master'
Jun 28, 2021
11cf5ef
Merge remote-tracking branch 'root_branch/master'
Sep 16, 2021
abb742b
Merge remote-tracking branch 'root_branch/master'
Oct 1, 2021
0235ffa
Merge remote-tracking branch 'root_branch/master' into master
nmaeura Feb 16, 2022
a6bd0d8
Merge remote-tracking branch 'root_branch/master' into master
relaido Jun 27, 2022
49769b1
Merge remote-tracking branch 'root_branch/master' into master
relaido Jun 28, 2022
5efa09a
Merge remote-tracking branch 'root_branch/master' into master
relaido Jul 20, 2022
2b0c7be
Merge remote-tracking branch 'root_branch/master' into master
relaido Jul 24, 2022
6a50b3c
Merge remote-tracking branch 'root_branch/master' into master
relaido Jul 26, 2022
7bd99bf
Merge remote-tracking branch 'root_branch/master' into master
relaido Jul 27, 2022
913bd3e
Merge remote-tracking branch 'root_branch/master'
relaido Jul 29, 2022
9ea3263
Merge remote-tracking branch 'root_branch/master'
Nov 15, 2022
8f90a53
Merge remote-tracking branch 'root_branch/master'
relaido Oct 31, 2023
cdf4bc3
Merge remote-tracking branch 'root_branch/master'
relaido Nov 26, 2023
63173cb
Merge remote-tracking branch 'root_branch/master'
relaido Feb 23, 2024
31a7a27
Merge remote-tracking branch 'root_branch/master'
relaido Apr 3, 2024
a083013
Merge remote-tracking branch 'root_branch/master'
relaido Apr 10, 2024
72381db
Merge remote-tracking branch 'root_branch/master'
relaido Jun 12, 2024
07439ca
Add placementId to renderAd parameters
relaido Jun 12, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/relaidoBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import { isSlotMatchingAdUnitCode } from '../libraries/gptUtils/gptUtils.js';

const BIDDER_CODE = 'relaido';
const BIDDER_DOMAIN = 'api.relaido.jp';
const ADAPTER_VERSION = '1.2.0';
const ADAPTER_VERSION = '1.2.1';
const DEFAULT_TTL = 300;
const UUID_KEY = 'relaido_uuid';

Expand Down Expand Up @@ -270,6 +270,7 @@ function outstreamRender(bid) {
height: bid.height,
vastXml: bid.vastXml,
mediaType: bid.mediaType,
placementId: bid.placementId,
});
});
}
Expand Down
21 changes: 21 additions & 0 deletions test/spec/modules/relaidoBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,11 @@ describe('RelaidoAdapter', function () {
}]
}
};
window.RelaidoPlayer = {
renderAd: function() {
return null;
}
};
});

afterEach(() => {
Expand Down Expand Up @@ -569,4 +574,20 @@ describe('RelaidoAdapter', function () {
expect(query.ref).to.include(window.location.href);
});
});

describe('spec.outstreamRender', function () {
it('Should to pass a Bid to renderAd', function () {
const bidResponses = spec.interpretResponse(serverResponse, serverRequest);
const response = bidResponses[0];
sinon.spy(window.RelaidoPlayer, 'renderAd');
response.renderer.render(response);
const renderCall = window.RelaidoPlayer.renderAd.getCall(0);
const arg = renderCall.args[0];
expect(arg.width).to.equal(640);
expect(arg.height).to.equal(360);
expect(arg.vastXml).to.equal('<VAST version="3.0"><Ad><InLine></InLine></Ad></VAST>');
expect(arg.mediaType).to.equal(VIDEO);
expect(arg.placementId).to.equal(100000);
});
});
});