Setupad adapter: param change and minor fixes

[eldzis]

Type of change

• Bugfix

• Feature

• New bidder adapter

• Updated bidder adapter

• Code style update (formatting, local variables)

• Refactoring (no functional changes, no api changes)

• Build related changes

• CI related changes

• Does this change affect user-facing APIs or examples documented on http://prebid.org?

• Other

Description of change

Changed account_id param from optional to required, updated tests accordingly and made a minor bug fix related to URL encoding for REPORT_ENDPOINT. &currency and &timestamp params were encoded as "¤cy=" and "×tamp=" during bundling process.

Other information

SETUPAD prebid.github.io PR: prebid/prebid.github.io#5411

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/nextMillenniumBidAdapter.js has 9 duplicated lines with modules/setupadBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/nextMillenniumBidAdapter.js has 9 duplicated lines with modules/setupadBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

[patmmccann]

Hi, the getAd function appears to duplicated in your adapter and another. Please modify both to import it, thanks!

[eldzis]

Hi @patmmccann, after closer inspection I stripped down the function to suit only our adapter needs and refactored to make it more readable. Now there is no duplicated code and as the function is very basic I don't think there's a need for moving main nextMillenium getAd function and importing it as it would only add more unnecessary code to our adapter.