Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smaato Bid Adapter: add DSA support #11789

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

tetianaatsmaato
Copy link
Contributor

Type of change

  • Feature

  • Updated bidder adapter

  • Refactoring (no functional changes, no api changes)

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
    Yes, here is the PR

Description of change

  • added DSA support for Smaato adapter
  • removed code duplication

Other information

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

  • modules/smaatoBidAdapter.js has 11 duplicated lines with modules/smaatoBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

@ChrisHuie ChrisHuie self-assigned this Jun 13, 2024
@ChrisHuie ChrisHuie merged commit 13c3dbb into prebid:master Jun 13, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants