Magnite Analytics: Minor fix for default rule name #11791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmmccann
reviewed
Jun 13, 2024
| // beforeEach(() => { | ||
| // magniteAdapter.enableAnalytics({ | ||
| // options: { | ||
| // cookieles: undefined |
There was a problem hiding this comment.
it is on the comment now, but was spelling causing an issue?
There was a problem hiding this comment.
no it was something else (mot initializing the variable), this bit of code just does not even do anything so I commented out while testing and forgot to remove, I deleted now.
patmmccann
reviewed
Jun 13, 2024
| afterEach(() => { | ||
| magniteAdapter.disableAnalytics(); | ||
| }) | ||
| it('should not add cokieless and preserve original rule name', () => { |
patmmccann
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
We would not send
ruleif did not detect cookieless which is not right! Set default now.