Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build system: increase heap size for test-coverage #11792

Merged
merged 5 commits into from
Jun 13, 2024

Conversation

dgirardi
Copy link
Collaborator

Type of change

  • Build related changes

Description of change

Fixes #11763

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

  • gulpfile.js has 9 duplicated lines with gulpfile.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

  • gulpfile.js has 9 duplicated lines with gulpfile.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

1 similar comment
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

  • gulpfile.js has 9 duplicated lines with gulpfile.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

  • gulpfile.js has 9 duplicated lines with gulpfile.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

  • gulpfile.js has 9 duplicated lines with gulpfile.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

1 similar comment
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

  • gulpfile.js has 9 duplicated lines with gulpfile.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

  • gulpfile.js has 9 duplicated lines with gulpfile.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

1 similar comment
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

  • gulpfile.js has 9 duplicated lines with gulpfile.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

@patmmccann patmmccann merged commit 19131b9 into prebid:master Jun 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gulp test-coverage ends with an error
3 participants