Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SmartyadsBidAdapter: remove usprivacy #11829

Merged
merged 16 commits into from
Jun 26, 2024
Merged

SmartyadsBidAdapter: remove usprivacy #11829

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
71eb4c0
SmartyadsBidAdapter remove usprivacy
vrishko Jun 19, 2024
8e5b0d0
refactor
vrishko Jun 19, 2024
4e41da7
refactor
vrishko Jun 19, 2024
01abf1e
remove unusable code
vrishko Jun 19, 2024
b59be78
try to fix duplicated code
vrishko Jun 19, 2024
0e4961e
try to fix duplicated code
vrishko Jun 19, 2024
42804e1
smallfixes
vrishko Jun 19, 2024
f1f92fd
smallfixes
vrishko Jun 19, 2024
fb4c77c
smallfix
vrishko Jun 19, 2024
0e93daf
tests fix
vrishko Jun 19, 2024
364eeae
revert fixes
vrishko Jun 20, 2024
01c11ec
remove language
vrishko Jun 20, 2024
cda046c
move getAdUrlByRegion to libs
vrishko Jun 20, 2024
07c6a4b
merge master
vrishko Jun 25, 2024
3d7f639
refactor
vrishko Jun 25, 2024
27627c2
undo creative functions
vrishko Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 14 additions & 15 deletions modules/smartyadsBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,19 +79,19 @@ export const spec = {
let location;
location = bidderRequest?.refererInfo ?? null;
let placements = [];

let request = {
'placements': placements,
'deviceWidth': winTop.screen.width,
'deviceHeight': winTop.screen.height,
'host': location?.domain,
'page': location?.page,
'language': (navigator && navigator.language) ? navigator.language : '',
'secure': 1,
'host': location?.domain ?? '',
'page': location?.page ?? '',
'coppa': config.getConfig('coppa') === true ? 1 : 0,
Copy link
Collaborator

@patmmccann patmmccann Jun 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will not be accepting tricks to fool the duplication check

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patmmccann OK, but how can I fix that? I saw the report and duplication check marks, for example, the isBidResponseValid function is used in lots of adapters and looks almost the same.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check out this work in progress from an adapter structured very similar to yours

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MaksymTeqBlaze@0249eb7

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patmmccann I'm sorry, but I still don't get it. The previous version of the isBidResponseValid function was flagged as duplicate code by your tool, but it doesn't need any updates, right? And the same function with same code is used in other adapters

Copy link
Collaborator

@patmmccann patmmccann Jun 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You and other modules have duplicate code, we need you to move common functions into libraries before making further updates to your adapter

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#8527 has an example on how to move common functions into a library

'placements': placements,
'eeid': validBidRequests[0]?.userIdAsEids,
'ifa': bidderRequest?.ortb2?.device?.ifa,
};
request.language.indexOf('-') != -1 && (request.language = request.language.split('-')[0])

if (bidderRequest) {
if (bidderRequest.gdprConsent) {
request.gdpr = bidderRequest.gdprConsent
Expand Down Expand Up @@ -129,16 +129,15 @@ export const spec = {
}
},

interpretResponse: (serverResponse) => {
let response = [];
serverResponse = serverResponse.body;
for (let i = 0; i < serverResponse.length; i++) {
let resItem = serverResponse[i];
if (isBidResponseValid(resItem)) {
response.push(resItem);
}
}
return response;
interpretResponse: (response) => {
let result = [];
const respData = response.body;

respData.forEach(resp => {
if (isBidResponseValid(resp)) response.push(resp);
});

return result;
},

getUserSyncs: (syncOptions, serverResponses = [], gdprConsent = {}, uspConsent = '', gppConsent = '') => {
Expand Down