PubMatic Analytics Adapter : Logging MultiBids from bidders #11844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 5, 2024 12:21
patmmccann
requested changes
Jun 20, 2024
| @@ -407,7 +417,7 @@ function executeBidsLoggerCall(e, highestCpmBids) { | |||
| 'au': origAdUnit.owAdUnitId || getGptSlotInfoForAdUnitCode(adUnitId)?.gptSlot || adUnitId, | |||
| 'mt': getAdUnitAdFormats(origAdUnit), | |||
| 'sz': getSizesForAdUnit(adUnit, adUnitId), | |||
| 'ps': gatherPartnerBidsForAdUnitForLogger(adUnit, adUnitId, highestCpmBids.filter(bid => bid.adUnitCode === adUnitId)), | |||
| 'ps': gatherPartnerBidsForAdUnitForLogger(adUnit, adUnitId, highestCpmBids.filter(bid => bid.adUnitCode === adUnitId), e), | |||
There was a problem hiding this comment.
can you also fix this?
Prebid.js/modules/pubmaticAnalyticsAdapter.js
Line 404 in 4fc7f88
'$prebid.version$' works, you do not need to import the global for it
patmmccann
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Earlier, we were not logging the multibids from bidders. With this update, we have added support for logging multibids. This enhancement ensures that all bids from bidders are recorded, providing better transparency and insights into the bidding process
Other information