New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linter checks: dom manipulation, network traffic, and direct storage access && bugfixes: unauthorized storage access #11884

Merged

patmmccann merged 75 commits into master from patmmccann-patch-10

Jul 4, 2024

Collaborator

patmmccann commented Jun 28, 2024 •

edited

Loading

related: #11853 which should replace with storage manager

note: this isn't currently working, the linter isnt failing any files for any of these new checks, including relevate health, which is bypassing consent checks


          relevatehealthBidAdapter.js: bugfix for storage used without consent

3b21571

patmmccann requested a review from spotxslagle

June 28, 2024 14:54

patmmccann assigned spotxslagle

patmmccann added the bugfix label

github-actions bot commented Jun 28, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/deepintentBidAdapter.js has 8 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 17 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 6 duplicated lines with modules/relevatehealthBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀


          Update index.js

0491a7e

github-actions bot commented Jun 28, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/deepintentBidAdapter.js has 8 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 17 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 6 duplicated lines with modules/relevatehealthBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀


          Update index.js

c624d74

github-actions bot commented Jun 28, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/deepintentBidAdapter.js has 8 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 17 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 6 duplicated lines with modules/relevatehealthBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀


          Update index.js

b81d4dc

github-actions bot commented Jun 28, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/deepintentBidAdapter.js has 8 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 17 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 6 duplicated lines with modules/relevatehealthBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀


          Update index.js

5971e5a

github-actions bot commented Jun 28, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/deepintentBidAdapter.js has 8 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 17 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 6 duplicated lines with modules/relevatehealthBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀


          Update index.js

a2cdfa0

github-actions bot commented Jun 28, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

plugins/eslint/index.js has 14 duplicated lines with plugins/eslint/index.js
modules/deepintentBidAdapter.js has 8 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 17 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 6 duplicated lines with modules/relevatehealthBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀


          Update index.js

847c994

github-actions bot commented Jun 28, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/deepintentBidAdapter.js has 8 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 17 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 6 duplicated lines with modules/relevatehealthBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀


          Update index.js

9f494c9

github-actions bot commented Jun 28, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/deepintentBidAdapter.js has 8 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 17 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 6 duplicated lines with modules/relevatehealthBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀


          Update index.js

github-actions bot commented Jun 28, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/deepintentBidAdapter.js has 8 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 17 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 6 duplicated lines with modules/relevatehealthBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀


          Update relevatehealthBidAdapter.js

054fbca

github-actions bot commented Jun 28, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/deepintentBidAdapter.js has 8 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 17 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 6 duplicated lines with modules/relevatehealthBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀


          Update index.js

78a7623

github-actions bot commented Jun 28, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/deepintentBidAdapter.js has 8 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 17 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 6 duplicated lines with modules/relevatehealthBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀


          Update index.js

68b864e

github-actions bot commented Jun 28, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/deepintentBidAdapter.js has 8 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 17 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 6 duplicated lines with modules/relevatehealthBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀


          Update index.js

886ebc1

github-actions bot commented Jun 28, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/deepintentBidAdapter.js has 8 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 17 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 6 duplicated lines with modules/relevatehealthBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀


          Update index.js

ff8a0be

github-actions bot commented Jul 1, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/sonobiBidAdapter.js has 13 duplicated lines with modules/winrBidAdapter.js
modules/freewheel-sspBidAdapter.js has 9 duplicated lines with modules/invibesBidAdapter.js
modules/etargetBidAdapter.js has 10 duplicated lines with modules/integr8BidAdapter.js
modules/dspxBidAdapter.js has 12 duplicated lines with modules/stvBidAdapter.js
modules/dspxBidAdapter.js has 15 duplicated lines with modules/radsBidAdapter.js
modules/dspxBidAdapter.js has 13 duplicated lines with modules/stvBidAdapter.js
modules/dspxBidAdapter.js has 16 duplicated lines with modules/stvBidAdapter.js
modules/dspxBidAdapter.js has 18 duplicated lines with modules/stvBidAdapter.js
modules/dspxBidAdapter.js has 69 duplicated lines with modules/stvBidAdapter.js
modules/dspxBidAdapter.js has 29 duplicated lines with modules/stvBidAdapter.js
modules/dspxBidAdapter.js has 40 duplicated lines with modules/stvBidAdapter.js
modules/dspxBidAdapter.js has 30 duplicated lines with modules/stvBidAdapter.js
modules/dspxBidAdapter.js has 23 duplicated lines with modules/stvBidAdapter.js
modules/dspxBidAdapter.js has 7 duplicated lines with modules/showheroes-bsBidAdapter.js
modules/deepintentBidAdapter.js has 8 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 17 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 6 duplicated lines with modules/relevatehealthBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀


          refactor custom linter rules

5d4f6b2

github-actions bot commented Jul 1, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/sonobiBidAdapter.js has 13 duplicated lines with modules/winrBidAdapter.js
modules/deepintentBidAdapter.js has 8 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 17 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 6 duplicated lines with modules/relevatehealthBidAdapter.js
modules/anPspParamsConverter.js has 12 duplicated lines with modules/dgkeywordRtdProvider.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

dgirardi added 2 commits

July 1, 2024 13:39


          Merge branch 'master' into patmmccann-patch-10

c8303aa


          use TODO and comments instead of quietly removing rule-breaking code

5973d8f

github-actions bot commented Jul 1, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/sonobiBidAdapter.js has 13 duplicated lines with modules/winrBidAdapter.js
modules/deepintentBidAdapter.js has 8 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 17 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 6 duplicated lines with modules/relevatehealthBidAdapter.js
modules/anPspParamsConverter.js has 12 duplicated lines with modules/dgkeywordRtdProvider.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀


          Add linter GH action

831ea69

github-actions bot commented Jul 1, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/sonobiBidAdapter.js has 13 duplicated lines with modules/winrBidAdapter.js
modules/deepintentBidAdapter.js has 8 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 17 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 6 duplicated lines with modules/relevatehealthBidAdapter.js
modules/anPspParamsConverter.js has 12 duplicated lines with modules/dgkeywordRtdProvider.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀


          Fix linter workflow name

44362d8

github-actions bot commented Jul 1, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/sonobiBidAdapter.js has 13 duplicated lines with modules/winrBidAdapter.js
modules/deepintentBidAdapter.js has 8 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 17 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 6 duplicated lines with modules/relevatehealthBidAdapter.js
modules/anPspParamsConverter.js has 12 duplicated lines with modules/dgkeywordRtdProvider.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

dgirardi added 7 commits

July 1, 2024 15:39


          Run npm ci on linter check

e4ece94


          Filter out missing (new) files

01f8406


          Do not fail on linter failure

5b33a6a


          swap continue-on-error


          remove spurious condition


          Improve comment

5e1cbb3


          Fix links for duplication checker comments

5a790c0

github-actions bot commented Jul 1, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/sonobiBidAdapter.js has 13 duplicated lines with modules/winrBidAdapter.js
modules/deepintentBidAdapter.js has 8 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 17 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 6 duplicated lines with modules/relevatehealthBidAdapter.js
modules/anPspParamsConverter.js has 12 duplicated lines with modules/dgkeywordRtdProvider.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀


          Filter out negative deltas

aecee10

github-actions bot commented Jul 1, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/sonobiBidAdapter.js has 13 duplicated lines with modules/winrBidAdapter.js
modules/deepintentBidAdapter.js has 8 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 17 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 6 duplicated lines with modules/relevatehealthBidAdapter.js
modules/anPspParamsConverter.js has 12 duplicated lines with modules/dgkeywordRtdProvider.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀


          Update linter warning comment

425fcba

github-actions bot commented Jul 1, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/sonobiBidAdapter.js has 13 duplicated lines with modules/winrBidAdapter.js
modules/deepintentBidAdapter.js has 8 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 17 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 6 duplicated lines with modules/relevatehealthBidAdapter.js
modules/anPspParamsConverter.js has 12 duplicated lines with modules/dgkeywordRtdProvider.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

spotxslagle approved these changes

View reviewed changes

Contributor

spotxslagle left a comment

LGTM


          Merge branch 'master' into patmmccann-patch-10

ffa9b9d

github-actions bot commented Jul 4, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/sonobiBidAdapter.js has 13 duplicated lines with modules/winrBidAdapter.js
modules/deepintentBidAdapter.js has 8 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 17 duplicated lines with modules/relevatehealthBidAdapter.js
modules/deepintentBidAdapter.js has 6 duplicated lines with modules/relevatehealthBidAdapter.js
modules/anPspParamsConverter.js has 12 duplicated lines with modules/dgkeywordRtdProvider.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀


          Update .eslintrc.js

7acba6b

patmmccann merged commit a4cc27c into master

1 of 3 checks passed

patmmccann deleted the patmmccann-patch-10 branch

July 4, 2024 11:03

DecayConstant pushed a commit to mediavine/Prebid.js that referenced this pull request


          Linter checks: dom manipulation, network traffic, and direct storage …

73481bb

…access && bugfixes: unauthorized storage access (prebid#11884)

* relevatehealthBidAdapter.js: bugfix for storage used without consent

* Update index.js

* Update index.js

* Update index.js

* Update index.js

* Update index.js

* Update index.js

* Update index.js

* Update index.js

* Update relevatehealthBidAdapter.js

* Update index.js

* Update index.js

* Update index.js

* Update index.js

* Update index.js

* Update .eslintrc.js

* Update index.js

* Update relevatehealthBidAdapter.js

* Update 33acrossAnalyticsAdapter.js

* Update index.js

* Update index.js

* Update 33acrossAnalyticsAdapter.js

* Update index.js

* Update ampliffyBidAdapter.js

* Update index.js

* Update invibesBidAdapter.js

* Update growthCodeAnalyticsAdapter.js

* Update fintezaAnalyticsAdapter.js

* Update growthCodeAnalyticsAdapter.js

* Update etargetBidAdapter.js

* Update dspxBidAdapter.js

* Update cwireBidAdapter.js

* Update cwireBidAdapter.js

* Update ampliffyBidAdapter.js

* Update etargetBidAdapter.js

* Update dspxBidAdapter.js

* Update fintezaAnalyticsAdapter.js

* Update ampliffyBidAdapter.js

* Update adlooxAnalyticsAdapter.js

* Update invibesBidAdapter.js

* Update fintezaAnalyticsAdapter.js

* Update dspxBidAdapter.js

* Update connectIdSystem.js

* Update automatadAnalyticsAdapter.js

* Update sonobiBidAdapter.js

* Update contxtfulRtdProvider.js

* Update sonobiBidAdapter.js

* Update contxtfulRtdProvider.js

* Update index.js

* Update cleanioRtdProvider.js

* Update connectIdSystem.js

* Update geoedgeRtdProvider.js

* Update growthCodeRtdProvider.js

* Update sirdataRtdProvider.js

* Update sirdataRtdProvider.js

* Update contxtfulRtdProvider_spec.js

* Update contxtfulRtdProvider_spec.js

* Update index.js

Fix duplication

* Update index.js

* refactor custom linter rules

* use TODO and comments instead of quietly removing rule-breaking code

* Add linter GH action

* Fix linter workflow name

* Run npm ci on linter check

* Filter out missing (new) files

* Do not fail on linter failure

* swap continue-on-error

* remove spurious condition

* Improve comment

* Fix links for duplication checker comments

* Filter out negative deltas

* Update linter warning comment

* Update .eslintrc.js

---------

Co-authored-by: Demetrio Girardi <[email protected]>

mefjush pushed a commit to adhese/Prebid.js that referenced this pull request


          Linter checks: dom manipulation, network traffic, and direct storage …

…access && bugfixes: unauthorized storage access (prebid#11884)

* relevatehealthBidAdapter.js: bugfix for storage used without consent

* Update index.js

* Update index.js

* Update index.js

* Update index.js

* Update index.js

* Update index.js

* Update index.js

* Update index.js

* Update relevatehealthBidAdapter.js

* Update index.js

* Update index.js

* Update index.js

* Update index.js

* Update index.js

* Update .eslintrc.js

* Update index.js

* Update relevatehealthBidAdapter.js

* Update 33acrossAnalyticsAdapter.js

* Update index.js

* Update index.js

* Update 33acrossAnalyticsAdapter.js

* Update index.js

* Update ampliffyBidAdapter.js

* Update index.js

* Update invibesBidAdapter.js

* Update growthCodeAnalyticsAdapter.js

* Update fintezaAnalyticsAdapter.js

* Update growthCodeAnalyticsAdapter.js

* Update etargetBidAdapter.js

* Update dspxBidAdapter.js

* Update cwireBidAdapter.js

* Update cwireBidAdapter.js

* Update ampliffyBidAdapter.js

* Update etargetBidAdapter.js

* Update dspxBidAdapter.js

* Update fintezaAnalyticsAdapter.js

* Update ampliffyBidAdapter.js

* Update adlooxAnalyticsAdapter.js

* Update invibesBidAdapter.js

* Update fintezaAnalyticsAdapter.js

* Update dspxBidAdapter.js

* Update connectIdSystem.js

* Update automatadAnalyticsAdapter.js

* Update sonobiBidAdapter.js

* Update contxtfulRtdProvider.js

* Update sonobiBidAdapter.js

* Update contxtfulRtdProvider.js

* Update index.js

* Update cleanioRtdProvider.js

* Update connectIdSystem.js

* Update geoedgeRtdProvider.js

* Update growthCodeRtdProvider.js

* Update sirdataRtdProvider.js

* Update sirdataRtdProvider.js

* Update contxtfulRtdProvider_spec.js

* Update contxtfulRtdProvider_spec.js

* Update index.js

Fix duplication

* Update index.js

* refactor custom linter rules

* use TODO and comments instead of quietly removing rule-breaking code

* Add linter GH action

* Fix linter workflow name

* Run npm ci on linter check

* Filter out missing (new) files

* Do not fail on linter failure

* swap continue-on-error

* remove spurious condition

* Improve comment

* Fix links for duplication checker comments

* Filter out negative deltas

* Update linter warning comment

* Update .eslintrc.js

---------

Co-authored-by: Demetrio Girardi <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels