Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adagio Bid Adapter: fix typo #11895

Conversation

osazos
Copy link
Collaborator

@osazos osazos commented Jul 1, 2024

Type of change

  • Bugfix

Description of change

Typo calling the deepAccess function.

Copy link

github-actions bot commented Jul 1, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

@patmmccann patmmccann self-assigned this Jul 1, 2024
@patmmccann
Copy link
Collaborator

@osazos please continue to work on your duplication in a future pr

@patmmccann patmmccann merged commit 4e470c5 into prebid:master Jul 1, 2024
2 of 4 checks passed
@osazos
Copy link
Collaborator Author

osazos commented Jul 4, 2024

@osazos please continue to work on your duplication in a future pr

Hi @patmmccann this is planed to be addressed this month.

@osazos osazos deleted the bug/sc-13715/adagiobidadapter-fix-auction-id branch July 15, 2024 12:16
DecayConstant pushed a commit to mediavine/Prebid.js that referenced this pull request Jul 18, 2024
mefjush pushed a commit to adhese/Prebid.js that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants