symitriDapRtdProvider : initial release and update akamaiDapRTD to import from symitri #11900
Conversation
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀 |
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀 |
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀 |
| import {getStorageManager} from '../src/storageManager.js'; | ||
| import {submodule} from '../src/hook.js'; | ||
| import {isPlainObject, mergeDeep, logMessage, logInfo, logError} from '../src/utils.js'; | ||
| import { loadExternalScript } from '../src/adloader.js'; |
There was a problem hiding this comment.
I think adloader needs to be aware of your module for this import to succeed
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀 |
ChrisHuie
changed the title
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀 |
jpalladino84
force-pushed
the
SYM-2-rename-akamaiDapRtdProvider
branch
from
4b68e31
to
3b8a9f4
Compare
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀 |
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀 |
jpalladino84
force-pushed
the
SYM-2-rename-akamaiDapRtdProvider
branch
from
4705e73
to
300cc9f
Compare
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀 |
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀 |
jpalladino84
force-pushed
the
SYM-2-rename-akamaiDapRtdProvider
branch
from
c60d3c0
to
300cc9f
Compare
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀 |
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀 |
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀 |
jpalladino84
force-pushed
the
SYM-2-rename-akamaiDapRtdProvider
branch
from
11dae71
to
6b8e3c3
Compare
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀 |
jpalladino84
force-pushed
the
SYM-2-rename-akamaiDapRtdProvider
branch
2 times, most recently
from
63e74f9
to
ac517cc
Compare
jpalladino84
force-pushed
the
SYM-2-rename-akamaiDapRtdProvider
branch
from
ac517cc
to
70d3afe
Compare
…port from symitri (prebid#11900) * SYM-2-rename-akamaiDapRtdProvider-to-symitriDapRtdProvider * encapsulate the Symitri module code in a create wrapper, instanciate in Akamai module * cleanup and sqaush --------- Co-authored-by: Jeff Palladino <[email protected]>
…port from symitri (prebid#11900) * SYM-2-rename-akamaiDapRtdProvider-to-symitriDapRtdProvider * encapsulate the Symitri module code in a create wrapper, instanciate in Akamai module * cleanup and sqaush --------- Co-authored-by: Jeff Palladino <[email protected]>
Type of change
New bidder adapter
Updated bidder adapter
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Description of change
Other information
updating Akamai-* Header references to Symitri-* prebid.github.io#5469