Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utils: Fix typo for GDPR/GPDR #11908

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

JulieLorin
Copy link
Collaborator

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Not sure if this is a useful fix, or if this might break something, but I think this typo might be error prone

Copy link

github-actions bot commented Jul 2, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

1 similar comment
Copy link

github-actions bot commented Jul 2, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

@patmmccann patmmccann self-requested a review July 2, 2024 10:09
@patmmccann patmmccann self-assigned this Jul 2, 2024
@patmmccann
Copy link
Collaborator

Doesn't look like it breaks anything to me

@patmmccann patmmccann changed the title Fix typo for GDPR/GPDR Utils: Fix typo for GDPR/GPDR Jul 2, 2024
@patmmccann patmmccann merged commit ac95edb into prebid:master Jul 2, 2024
3 of 5 checks passed
DecayConstant pushed a commit to mediavine/Prebid.js that referenced this pull request Jul 18, 2024
mefjush pushed a commit to adhese/Prebid.js that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants