permutiveRtd : transform integers to strings #11910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdifabio
approved these changes
Jul 2, 2024
ChrisHuie
changed the title
|
can you fix your jsdoc in this pr please? |
AntonioGargaro
force-pushed
the
EC-584/rtd-module-as-strings
branch
from
f3ab0b7
to
f3a5b42
Compare
|
Thanks for letting me know @patmmccann, fixed! |
DecayConstant
pushed a commit
to mediavine/Prebid.js
that referenced
this pull request
Jul 18, 2024
* fix(permutiveRtd): transform integers to strings * docs(permutiveRtd): update jsdoc to match function signatures * docs(permutiveRtd): fix ordering of jsdoc comments
mefjush
pushed a commit
to adhese/Prebid.js
that referenced
this pull request
Jul 19, 2024
* fix(permutiveRtd): transform integers to strings * docs(permutiveRtd): update jsdoc to match function signatures * docs(permutiveRtd): fix ordering of jsdoc comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Segments were read from persistence and used as is. We now safely transform all values read to a string.
This was causing issues when exposing segments into ortb2 that expected the segment IDs to be of type
string(see open rtd spec section 3.2.21 and 3.2.22).Added tests to ensure that values read from persistence are parsed safely.
Other information