Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgidBidAdapter: Add gpid value to bid request's imp[].ext #11916

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

Gaudeamus
Copy link
Contributor

@Gaudeamus Gaudeamus commented Jul 3, 2024

Type of change

  • Updated bidder adapter

Description of change

Adding gpid value for each bid request impression. No api changes

Copy link

github-actions bot commented Jul 3, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

@Gaudeamus
Copy link
Contributor Author

Gaudeamus commented Jul 3, 2024

Hello, as to deduplicating issue, I can't address it right now, and I will schedule time for this in the next sprints as it is unexpected task for the scope I've committed.
For now can we please proceed as it is?

@Gaudeamus
Copy link
Contributor Author

also, please explain how I should remedy the following, for both adapters are the same:

modules/mgidBidAdapter.js has 7 duplicated lines with modules/mgidBidAdapter.js

@patmmccann
Copy link
Collaborator

also, please explain how I should remedy the following, for both adapters are the same:

modules/mgidBidAdapter.js has 7 duplicated lines with modules/mgidBidAdapter.js

You do the same thing in each of those two cases. Define the constant you want outside of the switch and use it twice, or use an or inside your switch

@patmmccann
Copy link
Collaborator

Thanks for your attention on this matter soon, merging

@patmmccann patmmccann self-requested a review July 3, 2024 11:40
@patmmccann patmmccann self-assigned this Jul 3, 2024
@patmmccann patmmccann merged commit 8984260 into prebid:master Jul 3, 2024
4 of 5 checks passed
DecayConstant pushed a commit to mediavine/Prebid.js that referenced this pull request Jul 18, 2024
mefjush pushed a commit to adhese/Prebid.js that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants