pubmaticBidAdapter: battr in in banner requests #11917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync up prebid master to fork master
…bid-master # Conflicts: # modules/pubmaticBidAdapter.js # test/spec/modules/pubmaticBidAdapter_spec.js
Sync with prebid master
Merge pull request #5 from pm-nitin-shirsat/master
Sync with master
Sync with master
Sync with prebid master
Sync with Prebidd.js master
… plcmt parameter.
…lcmt parameter, if it is missing.
Sync with prebid master
Sync with master
Sync with master
Sync with master
patmmccann
requested changes
Jul 3, 2024
|
@patmmccann - Can you confirm that are you referring to read it from the below attached location? (i.e. adUnits -> ortb2Imp.banner.battr) |
|
You'll find it adjacent to this field if the publisher defines it that way Prebid.js/modules/pubmaticBidAdapter.js Line 772 in 74330a8 although i think ttd grabbed it in the wrong place Prebid.js/modules/ttdBidAdapter.js Line 244 in 7458aeb I think it is .banner.battr? |
|
Thank you @patmmccann . I will update PR adding support for battr, in following location, ortb2Imp.banner.battr |
patmmccann
approved these changes
Jul 4, 2024
patmmccann
changed the title
DecayConstant
pushed a commit
to mediavine/Prebid.js
that referenced
this pull request
Jul 18, 2024
…id#11917) * Implement functionality for deal priority * Update test cases * kick off test manually * Added support of GPP to PubMatic adapter * gpp_sid in user syncs supposed to encode as a string, not an array * Remove extra space * Remove trailing spaces * Remove the placement parameter and update test cases accordingly, Add plcmt parameter. * Supporting placement parameter and logging warning message, for the plcmt parameter, if it is missing. * Remove commented code * Added plcmt in the pubmaticBidAdapter.md file * Adding support for Banner battr object * reading battr from ortb2Imp.banner --------- Co-authored-by: Chris Huie <[email protected]>
mefjush
pushed a commit
to adhese/Prebid.js
that referenced
this pull request
Jul 19, 2024
…id#11917) * Implement functionality for deal priority * Update test cases * kick off test manually * Added support of GPP to PubMatic adapter * gpp_sid in user syncs supposed to encode as a string, not an array * Remove extra space * Remove trailing spaces * Remove the placement parameter and update test cases accordingly, Add plcmt parameter. * Supporting placement parameter and logging warning message, for the plcmt parameter, if it is missing. * Remove commented code * Added plcmt in the pubmaticBidAdapter.md file * Adding support for Banner battr object * reading battr from ortb2Imp.banner --------- Co-authored-by: Chris Huie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Added support of battr params to pubmaticBidAdapter in banner requests
Other information