Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anonymised RTD: Added Global Vendor List ID #11919

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Anonymised RTD: Added Global Vendor List ID #11919

merged 3 commits into from
Jul 3, 2024

Conversation

kyrylenko
Copy link
Contributor

Type of change

  • Other

Description of change

  • Added Global Vendor List ID (gvlid) during the submodule registration to manage user consent for accessing device storage (localStorage).
  • Minor correction in the documentation

Other information

@patmmccann patmmccann self-assigned this Jul 3, 2024
@patmmccann
Copy link
Collaborator

patmmccann commented Jul 3, 2024 •
edited
Loading

Please import the type:

/home/circleci/Prebid.js/modules/anonymisedRtdProvider.js
107:1 warning The type 'RtdSubmodule' is undefined jsdoc/no-undefined-types

eg

Prebid.js/modules/adagioRtdProvider.js

Line 33 in 7458aeb

* @typedef {import('../modules/rtdModule/index.js').RtdSubmodule} RtdSubmodule

patmmccann
patmmccann requested changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@patmmccann patmmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, one housekeeping request

@patmmccann patmmccann merged commit 9529ae3 into prebid:master Jul 3, 2024
5 checks passed
DecayConstant pushed a commit to mediavine/Prebid.js that referenced this pull request Jul 18, 2024
@kyrylenko @DecayConstant
Anonymised RTD: Added Global Vendor List ID (prebid#11919)
9571b26 
* adding gvlid during submodule registration

* updated docs

* review comment: import type to prevent warning

---------

Co-authored-by: Pavlo <[email protected]>
mefjush pushed a commit to adhese/Prebid.js that referenced this pull request Jul 19, 2024
@kyrylenko @mefjush
Anonymised RTD: Added Global Vendor List ID (prebid#11919)
1192ee9 
* adding gvlid during submodule registration

* updated docs

* review comment: import type to prevent warning

---------

Co-authored-by: Pavlo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patmmccann patmmccann patmmccann approved these changes

Assignees

@patmmccann patmmccann

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kyrylenko @patmmccann