Utiq id module: reduce log spamming #11922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The utiq module uses busy waiting to provide the `eid` values. Every busy waiting round it logs messages that are not actionable.
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀 |
patmmccann
approved these changes
Jul 4, 2024
DecayConstant
pushed a commit
to mediavine/Prebid.js
that referenced
this pull request
Jul 18, 2024
The utiq module uses busy waiting to provide the `eid` values. Every busy waiting round it logs messages that are not actionable.
mefjush
pushed a commit
to adhese/Prebid.js
that referenced
this pull request
Jul 19, 2024
The utiq module uses busy waiting to provide the `eid` values. Every busy waiting round it logs messages that are not actionable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The utiq module uses busy waiting to provide the
eidvalues. Every busy waiting round it logs messages that are not actionable.Type of change
Description of change
The utiq module uses busy waiting to provide the
eidvalues. Every busy waiting round it logs messages that are not actionable.Other information
FYI @jkthomas