DSPx Bid Adapter: add ortb2 content, topics support

[onlsol]

DSPx Bid Adapter: add ortb2 content, topics support

Type of change

• Feature

Description of change

Improved the adapters support for ortb content, userids, topics.

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/dspxBidAdapter.js has 12 duplicated lines with modules/stvBidAdapter.js
• modules/dspxBidAdapter.js has 11 duplicated lines with modules/radsBidAdapter.js
• modules/dspxBidAdapter.js has 13 duplicated lines with modules/stvBidAdapter.js
• modules/dspxBidAdapter.js has 18 duplicated lines with modules/stvBidAdapter.js
• modules/dspxBidAdapter.js has 47 duplicated lines with modules/stvBidAdapter.js
• modules/dspxBidAdapter.js has 23 duplicated lines with modules/stvBidAdapter.js
• modules/dspxBidAdapter.js has 29 duplicated lines with modules/stvBidAdapter.js
• modules/dspxBidAdapter.js has 40 duplicated lines with modules/stvBidAdapter.js
• modules/dspxBidAdapter.js has 30 duplicated lines with modules/stvBidAdapter.js
• modules/dspxBidAdapter.js has 23 duplicated lines with modules/stvBidAdapter.js
• modules/dspxBidAdapter.js has 7 duplicated lines with modules/showheroes-bsBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

[github-actions]

Tread carefully! This PR adds 6 linter errors (possibly disabled through directives):

• test/spec/modules/dspxBidAdapter_spec.js (+6 errors)

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/dspxBidAdapter.js has 12 duplicated lines with modules/stvBidAdapter.js
• modules/dspxBidAdapter.js has 11 duplicated lines with modules/radsBidAdapter.js
• modules/dspxBidAdapter.js has 13 duplicated lines with modules/stvBidAdapter.js
• modules/dspxBidAdapter.js has 18 duplicated lines with modules/stvBidAdapter.js
• modules/dspxBidAdapter.js has 47 duplicated lines with modules/stvBidAdapter.js
• modules/dspxBidAdapter.js has 23 duplicated lines with modules/stvBidAdapter.js
• modules/dspxBidAdapter.js has 29 duplicated lines with modules/stvBidAdapter.js
• modules/dspxBidAdapter.js has 40 duplicated lines with modules/stvBidAdapter.js
• modules/dspxBidAdapter.js has 30 duplicated lines with modules/stvBidAdapter.js
• modules/dspxBidAdapter.js has 23 duplicated lines with modules/stvBidAdapter.js
• modules/dspxBidAdapter.js has 7 duplicated lines with modules/showheroes-bsBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

[patmmccann]

Hi! it appears DSPx and STV are very closely mirrored. Please see #11879 and #8527 and #11854 and #11877 for examples on fixing. Thanks!

[onlsol]

@patmmccann Hi, that's right, the stvBidAdapter has several similarities in requirements, code constructs, conditions and code comments as dspxBidAdapter.
As far as I see, none of them is related to the current PR's changes or commits.
Would it be possible to proceed with this PR as it is (type of change "feature")? If you agree, subsequently, in a separate PR, we could work on the maintenance/refactoring and move re-usable parts to bidderUtils.

[patmmccann]

Yes but please make sure that is your next pr; we are in the midst of an initiative to identify and consolidate duplicated code :)

[patmmccann]

btw feature is typically reserved for new modules, support for new media types, and changes to the core

[onlsol]

Understood, thanks for clarification.