Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adkernel Bid Adapter: add voisetech alias #11942

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

ckbo3hrk
Copy link
Contributor

@ckbo3hrk ckbo3hrk commented Jul 8, 2024

Type of change

  • Other

Description of change

Added alias for voisetech.com partner network

Copy link

github-actions bot commented Jul 8, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@patmmccann
Copy link
Collaborator

Hi there!, looks like there's an easy opportunity to import `

function getBidFloor(bid, mediaType, sizes) {
var floor;
var size = sizes.length === 1 ? sizes[0] : '*';
if (typeof bid.getFloor === 'function') {
const floorInfo = bid.getFloor({currency: 'USD', mediaType, size});
if (typeof floorInfo === 'object' && floorInfo.currency === 'USD' && !isNaN(parseFloat(floorInfo.floor))) {
floor = parseFloat(floorInfo.floor);
}
}
return floor;
}` in two of your adapters

Copy link

github-actions bot commented Jul 8, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@ckbo3hrk
Copy link
Contributor Author

ckbo3hrk commented Jul 8, 2024

@patmmccann Extracted getBidFloor function into a utility file.

@patmmccann patmmccann self-assigned this Jul 8, 2024
@patmmccann patmmccann self-requested a review July 8, 2024 14:42
@patmmccann
Copy link
Collaborator

@ckbo3hrk you may want to add your own gvlid to all these aliases like this #11871 . we found the tcf control module was limiting their use in europe

@patmmccann patmmccann merged commit c140dc0 into prebid:master Jul 8, 2024
4 of 6 checks passed
DecayConstant pushed a commit to mediavine/Prebid.js that referenced this pull request Jul 18, 2024
* Adkernel Bid Adapter: add voisetech alias

* Adkernel Bid Adapter: add voisetech alias
mefjush pushed a commit to adhese/Prebid.js that referenced this pull request Jul 19, 2024
* Adkernel Bid Adapter: add voisetech alias

* Adkernel Bid Adapter: add voisetech alias
@ckbo3hrk ckbo3hrk deleted the adkernel_voisetech branch August 21, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants