Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rise utils: initial commit #11951

Merged
merged 43 commits into from
Jul 16, 2024
Merged

Rise utils: initial commit #11951

merged 43 commits into from
Jul 16, 2024

Conversation

patmmccann
Copy link
Collaborator

@patmmccann patmmccann commented Jul 9, 2024 •
edited
Loading

attempt to begin a fix for #11897, as there are no behavior changes in the pr, tests aren't touched

@GeneGenie @zkosanovic @OronW @noamtzu @noamtzuberi @mdghousesaqlain

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Tread carefully! This PR adds 11 linter errors (possibly disabled through directives):

  • libraries/riseUtils/index.js (+6 errors)
  • modules/stnBidAdapter.js (+5 errors)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Tread carefully! This PR adds 5 linter errors (possibly disabled through directives):

  • modules/stnBidAdapter.js (+5 errors)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

  • modules/telariaBidAdapter.js (+1 error)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Tread carefully! This PR adds 3 linter errors (possibly disabled through directives):

  • modules/shinezBidAdapter.js (+3 errors)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Tread carefully! This PR adds 6 linter errors (possibly disabled through directives):

  • modules/riseBidAdapter.js (+3 errors)
  • modules/shinezBidAdapter.js (+3 errors)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Tread carefully! This PR adds 10 linter errors (possibly disabled through directives):

  • modules/openwebBidAdapter.js (+4 errors)
  • modules/riseBidAdapter.js (+3 errors)
  • modules/shinezBidAdapter.js (+3 errors)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Tread carefully! This PR adds 17 linter errors (possibly disabled through directives):

  • modules/openwebBidAdapter.js (+4 errors)
  • modules/publirBidAdapter.js (+7 errors)
  • modules/riseBidAdapter.js (+3 errors)
  • modules/shinezBidAdapter.js (+3 errors)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Tread carefully! This PR adds 14 linter errors (possibly disabled through directives):

  • modules/openwebBidAdapter.js (+4 errors)
  • modules/publirBidAdapter.js (+7 errors)
  • modules/riseBidAdapter.js (+3 errors)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):

  • modules/publirBidAdapter.js (+2 errors)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

  • modules/publirBidAdapter.js (+1 error)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@patmmccann patmmccann mentioned this pull request Jul 16, 2024
Open
10 tasks
@patmmccann patmmccann merged commit bb5dcef into master Jul 16, 2024
5 of 6 checks passed
@patmmccann patmmccann deleted the riseUtils branch July 16, 2024 12:30
DecayConstant pushed a commit to mediavine/Prebid.js that referenced this pull request Jul 18, 2024
@patmmccann @DecayConstant
Rise utils: initial commit (prebid#11951)
cf19952 
* Create index.js

* Update stnBidAdapter.js

* Update index.js

* Update stnBidAdapter.js

* Update telariaBidAdapter.js

* Update telariaBidAdapter.js

* Update shinezBidAdapter.js

* Update riseBidAdapter.js

* Update openwebBidAdapter.js

* Update publirBidAdapter.js

* Update shinezBidAdapter.js

* Update riseBidAdapter.js

* Update openwebBidAdapter.js

* Update publirBidAdapter.js

* Update index.js

* Update openwebBidAdapter.js

* Update shinezBidAdapter.js

* Update openwebBidAdapter.js

* Update shinezBidAdapter.js

* Update index.js

* Update shinezBidAdapter.js

* Update riseBidAdapter.js

* Update openwebBidAdapter.js

* Update index.js

* Update stnBidAdapter.js

* Update index.js

* Update index.js

* Update minutemediaBidAdapter.js

* Update publirBidAdapter.js

* Update index.js

* Update minutemediaBidAdapter.js

* Update publirBidAdapter.js

* Update publirBidAdapter.js

* Update publirBidAdapter.js

* Update publirBidAdapter.js

* Update publirBidAdapter.js

* Update publirBidAdapter.js

* Update publirBidAdapter.js

* Update publirBidAdapter.js

* Update index.js

* Update index.js

* Update publirBidAdapter.js

* Update publirBidAdapter.js
@patmmccann patmmccann mentioned this pull request Jul 19, 2024
Closed
2 tasks
mefjush pushed a commit to adhese/Prebid.js that referenced this pull request Jul 19, 2024
@patmmccann @mefjush
Rise utils: initial commit (prebid#11951)
0cc4ff3 
* Create index.js

* Update stnBidAdapter.js

* Update index.js

* Update stnBidAdapter.js

* Update telariaBidAdapter.js

* Update telariaBidAdapter.js

* Update shinezBidAdapter.js

* Update riseBidAdapter.js

* Update openwebBidAdapter.js

* Update publirBidAdapter.js

* Update shinezBidAdapter.js

* Update riseBidAdapter.js

* Update openwebBidAdapter.js

* Update publirBidAdapter.js

* Update index.js

* Update openwebBidAdapter.js

* Update shinezBidAdapter.js

* Update openwebBidAdapter.js

* Update shinezBidAdapter.js

* Update index.js

* Update shinezBidAdapter.js

* Update riseBidAdapter.js

* Update openwebBidAdapter.js

* Update index.js

* Update stnBidAdapter.js

* Update index.js

* Update index.js

* Update minutemediaBidAdapter.js

* Update publirBidAdapter.js

* Update index.js

* Update minutemediaBidAdapter.js

* Update publirBidAdapter.js

* Update publirBidAdapter.js

* Update publirBidAdapter.js

* Update publirBidAdapter.js

* Update publirBidAdapter.js

* Update publirBidAdapter.js

* Update publirBidAdapter.js

* Update publirBidAdapter.js

* Update index.js

* Update index.js

* Update publirBidAdapter.js

* Update publirBidAdapter.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisHuie ChrisHuie ChrisHuie approved these changes

@Rothalack Rothalack Awaiting requested review from Rothalack

Assignees

@ChrisHuie ChrisHuie

@Rothalack Rothalack

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@patmmccann @ChrisHuie @Rothalack