Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdagioAnalyticsAdapter: send PBA for all auctions #11961

Conversation

Abyfall
Copy link
Contributor

@Abyfall Abyfall commented Jul 11, 2024

⚠️ this PR should be merged after #11958 ⚠️

Type of change

  • Feature

Description of change

Other information

Based on #11958
Doc update prebid/prebid.github.io#5495

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@patmmccann
Copy link
Collaborator

adding the flag to indicate the merge order dependency

@patmmccann
Copy link
Collaborator

Can you please submit pr's to reduce deplication, for example you and the insiticator adapter have an identical function

@Abyfall Abyfall force-pushed the adagio-feature/adagioanalyticsadapter-update-pba-for-pbs branch from fe883d0 to f82eea3 Compare July 12, 2024 07:24
@patmmccann patmmccann self-assigned this Jul 15, 2024
@patmmccann patmmccann self-requested a review July 15, 2024 10:54
@patmmccann patmmccann merged commit 6a85621 into prebid:master Jul 15, 2024
6 checks passed
@osazos osazos deleted the adagio-feature/adagioanalyticsadapter-update-pba-for-pbs branch July 15, 2024 12:15
DecayConstant pushed a commit to mediavine/Prebid.js that referenced this pull request Jul 18, 2024
* AdagioAnalyticsAdapter: send PBA for all auctions

* AdagioAnalyticsAdapter: typo

* AdagioAnalyticsAdapter: update md file

---------

Co-authored-by: Olivier <[email protected]>
mefjush pushed a commit to adhese/Prebid.js that referenced this pull request Jul 19, 2024
* AdagioAnalyticsAdapter: send PBA for all auctions

* AdagioAnalyticsAdapter: typo

* AdagioAnalyticsAdapter: update md file

---------

Co-authored-by: Olivier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants