-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AdagioAnalyticsAdapter: send PBA for all auctions #11961
AdagioAnalyticsAdapter: send PBA for all auctions #11961
Conversation
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
adding the flag to indicate the merge order dependency |
Can you please submit pr's to reduce deplication, for example you and the insiticator adapter have an identical function |
fe883d0
to
f82eea3
Compare
* AdagioAnalyticsAdapter: send PBA for all auctions * AdagioAnalyticsAdapter: typo * AdagioAnalyticsAdapter: update md file --------- Co-authored-by: Olivier <[email protected]>
* AdagioAnalyticsAdapter: send PBA for all auctions * AdagioAnalyticsAdapter: typo * AdagioAnalyticsAdapter: update md file --------- Co-authored-by: Olivier <[email protected]>
Type of change
Description of change
organizationId
string requiredsite
string requiredOther information
Based on #11958
Doc update prebid/prebid.github.io#5495