Insticator: Update prebid-server bidder params for impressions

[shubhamc-ins]

Type of change

• Bugfix

• Feature

• New bidder adapter

• Updated bidder adapter

• Code style update (formatting, local variables)

• Refactoring (no functional changes, no api changes)

• Build related changes

• CI related changes

• Does this change affect user-facing APIs or examples documented on http://prebid.org?

• Other

Description of change

Other information

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/adagioBidAdapter.js has 9 duplicated lines with modules/insticatorBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

[shubhamc-ins]

Hey @patmmccann, as I can see in this PR changes, the general video validation check is being added to verify the video params.

I can write a similar check, which would pass duplication check for now but when the PR #11970 is merged, it would again be duplicated.

I can just add this ORTB_VIDEO_PARAMS validator in this PR and update insticator adaptor accordingly and rest changes can be continued on other PR.

Please let me know, what are your thoughts.
Thanks

[patmmccann]

My suggestion is let the robot complain for now, when the other pr merges, should be ready to address. Is that the same as your proposal?

What we don't want is to just silence the robot so we don't know where the opportunities are

[shubhamc-ins]

My suggestion is let the robot complain for now, when the other pr merges, should be ready to address. Is that the same as your proposal?

Okay @patmmccann , In that case This PR is ready. I'll address the duplication when #11970 PR merges, sounds right?

Please feel free to tag me once that is done.