Revert "Appnexus Bid Adapter: parse the currency from the bid if specified" #11995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ified (#…" This reverts commit 2fef9c2.
jsnellbaker
approved these changes
Jul 18, 2024
DecayConstant
pushed a commit
to mediavine/Prebid.js
that referenced
this pull request
Jul 18, 2024
…ified (#…" (prebid#11995) This reverts commit 2fef9c2.
mefjush
pushed a commit
to adhese/Prebid.js
that referenced
this pull request
Jul 19, 2024
…ified (#…" (prebid#11995) This reverts commit 2fef9c2.
|
The initial change was intended to fix currency conversion for the case when you have non-usd default currency. Can you please explain how it is supposed to work without it now? |
|
Unless I'm mistaken, I think that's what the prebid currency module is meant to help address? Can you explain your use-case more if the currency module can't help in the issue #11994 where it asked for the change to be reverted? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AppnexusBidAdapter have possibility to not able to use any currency other USD.
Reverts #11581
resolve #11994