docereeAdManager Bid Adapter : Updated bid adapter #11996
Conversation
| @@ -25,6 +25,7 @@ describe('docereeadmanager', function () { | |||
| userid: '', | |||
| zipcode: '', | |||
| userconsent: '', | |||
| platformUid: '' | |||
| }, | |||
There was a problem hiding this comment.
As discussed in the last submission, this needs some improvement. Also could you discuss why you're passing full names in the clear? This is a quite unusual practice
There was a problem hiding this comment.
This adapter has already been deployed and is actively used by several clients in production. The proposed alteration to the current signature could disrupt our workflows. The submitted modification involves a minor adjustment to the field 'userid' and the introduction of a new field ('mobile'). Please merge the changes with master to expedite availability of these changes in the adapter
There was a problem hiding this comment.
no changes will be merged without appropriate test coverage
There was a problem hiding this comment.
Hi; I talked with other prebid leadership, we decided to merge your pr with a few tweaks
| @@ -25,6 +25,7 @@ describe('docereeadmanager', function () { | |||
| userid: '', | |||
| zipcode: '', | |||
| userconsent: '', | |||
| platformUid: '' | |||
| }, | |||
There was a problem hiding this comment.
no changes will be merged without appropriate test coverage
|
Tread carefully! This PR adds 5 linter errors (possibly disabled through directives):
|
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Updated field for user inputs
Other information