MobianRtdModule: Add more signals from API endpoint to first-party data #11999
Conversation
modules/mobianRtdProvider.js
Outdated
| /** | ||
| * This module adds the Mobian RTD provider to the real time data module | ||
| * The {@link module:modules/realTimeData} module is required | ||
| * @module modules/anonymisedRtdProvider |
There was a problem hiding this comment.
are you from idward / anonymised? do you mean to import their type?
There was a problem hiding this comment.
no -- that's embarrassing. I've had trouble getting the build to include the real time data module without including it explicitly, and hoped that typing would help. Will remove...
There was a problem hiding this comment.
Add yourself to .submodules.js
There was a problem hiding this comment.
Prebid.js/modules/.submodules.json
Line 88 in dc6c0c3
|
(Thanks -- fixed!! In the last commit, we've fixed another bug where the browser interprets the API response as a string, in which case we need to call |
modules/mobianRtdProvider.js
Outdated
| @@ -24,6 +22,21 @@ export const mobianBrandSafetySubmodule = { | |||
| function init() { | |||
| return true; | |||
| } | |||
|
|
|||
| function safeJSONParse(input) { | |||
There was a problem hiding this comment.
can you import this?
Line 1107 in 465096c
There was a problem hiding this comment.
Thanks! I'll just import this, I haven't got any reason to believe that in fact the API response ever came in pre-parsed. It'll be a bit cause I need to fix the tests.
Type of change
Description of change
In addition to adding Mobian's determination of brand safety to the first party data, we now also add its
determination of sentiment, emotion, and garm risk categories.