Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rise Utils: Bugfixes #12012

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Conversation

zkosanovic
Copy link
Contributor

@zkosanovic zkosanovic commented Jul 22, 2024

Type of change

  • Bugfix

Description of change

  1. Rise server expects loop parameter to be an integer, so it should default to 0 instead of an empty string.
  2. For page_domain parameter, we should get the value from refererInfo if present.

Fixes #11289

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@patmmccann patmmccann self-requested a review July 22, 2024 14:32
@patmmccann patmmccann self-assigned this Jul 22, 2024
@patmmccann patmmccann linked an issue Jul 22, 2024 that may be closed by this pull request
@patmmccann patmmccann merged commit 1192400 into prebid:master Jul 22, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants