Mobian RTD Module: remove reference to garm in output of mobian brand-safety #12014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehb-mtk
commented
Jul 22, 2024
| @@ -23,70 +23,63 @@ describe('Mobian RTD Submodule', function () { | |||
| ajaxStub.restore(); | |||
| }); | |||
|
|
|||
| it('should return no_risk when server responds with garm_no_risk', function () { | |||
| it('should return risk level when server responds with garm_risk', function () { | |||
There was a problem hiding this comment.
the diff on the tests looks huge, but isn't -- we're just removing the testing of the old garm_x_risk since we always expect garm_risk coming in.
patmmccann
approved these changes
Jul 22, 2024
|
i feel your pain with this make work, approving |
Merged
2 tasks
spotxslagle
added a commit
that referenced
this pull request
Jul 23, 2024
* remove reference to garm in output of mobian brand-safety (#12014) * Update PULL_REQUEST_TEMPLATE.md (#12019) * Reading pmp from ortb2Imp object (#12020) --------- Co-authored-by: ehb-mtk <[email protected]> Co-authored-by: Patrick McCann <[email protected]> Co-authored-by: kapil-tuptewar <[email protected]>
spotxslagle
added a commit
that referenced
this pull request
Jul 23, 2024
* remove reference to garm in output of mobian brand-safety (#12014) * Update PULL_REQUEST_TEMPLATE.md (#12019) * Reading pmp from ortb2Imp object (#12020) --------- Co-authored-by: ehb-mtk <[email protected]> Co-authored-by: Patrick McCann <[email protected]> Co-authored-by: kapil-tuptewar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Our product team has asked us not to describe the given output as being created by GARM.
I also removed a loop that used to be necessary to compute the risk from the API output but is now redundant because the API output returns the risk directly.