PulsePoint Lite adpater changes #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: cleanup * ET-1691: minor * ET-1691: revert package.json change
ET-1850: Fixing #866
modules/pulsepointLiteBidAdapter.js
Outdated
| !!(bid && bid.params && bid.params.cp && bid.params.ct) | ||
| ), | ||
|
|
||
| buildRequests: bidRequest => { |
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks for pointing this out Anand. Opened a PR (prebid/prebid.github.io#380) on prebid.org to correct the docs. @snapwich will submit a PR to clarify the comments in the code.
Note that we also opted to rename the first parameter because there're actually two params formerly called "bidRequests" and "bidderRequest". This was kinda confusing, so we renamed the first to "validBidRequests". The second param isn't documented on prebid.org as it's expected to be needed only in rare cases, but is documented in the code.
There was a problem hiding this comment.
Thanks for clarifying @bretg
matthewlane
approved these changes
Oct 3, 2017
mkendall07
approved these changes
Oct 3, 2017
| import adaptermanager from 'src/adaptermanager'; | ||
| import { registerBidder } from 'src/adapters/bidderFactory'; | ||
|
|
||
| const NATIVE_DEFAULTS = { |
There was a problem hiding this comment.
These could go into native.js if they are per the spec (i think they are).
Doesn't need to change for merge though.
| /** | ||
| * Attempts to capture the referrer url. | ||
| */ | ||
| function referrer() { |
There was a problem hiding this comment.
this should also be a generic function (todo for utils).
vzhukovsky
added a commit
to aol/Prebid.js
that referenced
this pull request
Oct 25, 2017
….30.0 to aolgithub-master * commit '5a8d2bf93ee15071a78e24ac976103cacf3c6021': (35 commits) Added changelog entry. Prebid 0.30.1 Release Remove undefined variable usage (prebid#1662) fixes bug for IE when invalid value passed to parse (prebid#1657) Aliasbidder fix (prebid#1652) prebidAdapter secure support (prebid#1655) Increment pre version Prebid 0.30.0 Release Add native param support to mediaTypes (prebid#1625) PulsePoint Lite adpater changes (prebid#1630) Appnexus ast unittest updates (prebid#1654) Support aspect ratio specification for native images (prebid#1634) Revert changes for switch between client side and server side. (prebid#1653) rubicon converted to bidderFactory (prebid#1624) Add JSDoc for `pbjs.getAllWinningBids` (prebid#1566) Add ignore-loader to handle .md files (prebid#1646) fixed PBS cookie syncs (prebid#1637) Add placementId request param to Yieldmo bid adapter (prebid#1632) Adxcg analytics adapter (prebid#1599) Add publisher sub-id support to the Criteo adapter (prebid#1629) ...
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* ET-1691: Pulsepoint Analytics adapter for Prebid. (#1) * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: cleanup * ET-1691: minor * ET-1691: revert package.json change * Adding bidRequest to bidFactory.createBid method as per prebid#509 * ET-1765: Adding support for additional params in PulsePoint adapter (#2) * ET-1850: Fixing prebid#866 * Minor fix * Refactoring current functionality to work with bidderFactory (for 1.0 migration) * More tests. * Adding support for "app" requests. * fixing eslint issues * adding adapter documentation * minor doc update * removing usage of reserved keyword 'native'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Updates to the adapter to prepare for 1.0 upgrade.
Support for InApp parameters.
Test Page: http://projects.contextweb.com/av/prebid/1.0-pre/