Topics FPD module: initial release #8646
Conversation
|
Note that this affects anyone who's using FPD modules, by adding an additional promise resolution at the beginning of auctions - it was done with #8626 in mind. IMO this should wait for that to get merged as to not needlessly affect the majority of users (who are not using topics). |
dgirardi
added
feature
needs 2nd review
|
Note this has one review already from @vkimcm ; only needs one more |
|
Updated to merge in GreedyPromise; this is now mergable, however, note that the spot testing from #8630 was done before the changes you requested here @patmmccann. I used the example topics as reported there but the new logic is, technically, untested. |
| return topics; | ||
| } | ||
|
|
||
| const topicsData = getTopics().then((topics) => getTopicsData(getRefererInfo().domain, topics)); |
There was a problem hiding this comment.
It seems we should potentially use the domain of the url in https://developer.mozilla.org/en-US/docs/Web/API/Document/currentScript
Or perhaps a configuration override is sufficient.
Pubishers may wish to indicate the breadth of the footprint here, eg hearst.com instead of somemagazine.com or cafemedia.com instead of cafedelites.com.
The topics api results are reporteed to be dependent on the domain of the script which calls it.
There was a problem hiding this comment.
I'm not sure I understand - do you mean that topics will return different results if you use <script src="//rubicon.com/prebid.js" /> compared <script src="//appnexus.com/prebid.js" />? that seems insane.
There was a problem hiding this comment.
That's how it is described
There was a problem hiding this comment.
So it appears there's been some clarification:
"A design goal of the Topics API is to enable interest-based advertising without the sharing of information to more entities than is currently possible with third-party cookies. The Topics API proposes that topics can only be returned for API callers that have already observed them, within a limited timeframe.
Key Term
A Topics API caller is the entity that calls the document.browsingTopics() JavaScript method, and will use the topics returned by the method to help select relevant ads. Typically, a call to document.browsingTopics() would be from code included in a site from a third party such as an adtech platform. The browser determines the caller from the site of the current document. So, if you're a third party on a page, make sure you call the API from an iframe that your site owns."
This suggests only if you call the api from inside a frame and do the post-message will you get different behavior
Let's keep that for a follow up and cancel this change request to this pr
There was a problem hiding this comment.
@dgirardi testing successful
* Topics FPD module * Small improvements * Map taxonomyVersion to segtax, modelVersion to segclass * Convert fpdModule & topicsFpdModule to use GreedyPromise
* Topics FPD module * Small improvements * Map taxonomyVersion to segtax, modelVersion to segclass * Convert fpdModule & topicsFpdModule to use GreedyPromise
Type of change
Description of change
This adds a new
topicsFpdModulethat queries the topics api to populateuser.data.Since
document.browsingTopics()always returns an empty list for me, I need volunteers to test this in the real world.Other information
Closes #7968
Depends on #8626
Documentation TBD