Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Digital adapter: flag support for native 1.2 JS trackers in bid request #8701

Merged
merged 2 commits into from
Aug 1, 2022

Conversation

jbartek25
Copy link
Contributor

Type of change

  • Feature

Description of change

Improve Digital adapter: Include explicit declaration of native 1.2 JS imp tracker support in bid request. JS trackers were supported already but some DSPs (like DV360) now expect to see explicit confirmation in bid request.

@patmmccann
Copy link
Collaborator

did you not want to allow PBS adapter to see this as well if a publisher configures it? Also it seems like we're diverging from PBS adapter here; it would seem a publisher would want to choose this in a consistent way.

@patmmccann patmmccann self-assigned this Jul 18, 2022
@patmmccann patmmccann self-requested a review July 18, 2022 17:23
@jbartek25
Copy link
Contributor Author

Issue #8665 is about fixing the default in PBS adapter to make JS trackers enabled by default as was the case (and still is in many adapters) with native 1.1. Other bidder adapters which support native ads spec 1.1 all support JS trackers without restriction so in fact PBS adapter diverged by introducing the restriction in its default value and per @bretg's plan in #8665 (comment) the default can be changed in Prebid 8 aligning the native 1.1 and native 1.2 behaviour across adapters.

I'm eagerly waiting for the new ortb native support and will certainly make any native params configurable via adunit.native.ortb when adopting ortb.

As a side note: it's not our intention to have to ask the publisher for permission as in our interpretation of ortb native 1.2 spec the eventtrackers field is about whether JS trackers are supported or not, not whether they are allowed. It's not a privacy field and it's optional: If omitted, it's for DSP's discretion whether to include JS trackers in the response or not (that's how native 1.1 worked) and so our adapter is already handling JS trackers and the change in this PR just makes it explicit as DV360 started requiring it.

Screenshot 2022-07-19 at 09 20 03

@patmmccann
Copy link
Collaborator

Any chance you could give feeedback directly on #8086 ?

@jbartek25
Copy link
Contributor Author

@patmmccann let me put this PR on hold until next week.

@patmmccann
Copy link
Collaborator

@jbartek25 8086 is now merged, I think it is fair default this config in your adapter as long as publishers have some way to specify they prefer no js trackers on native

@jbartek25
Copy link
Contributor Author

I'll look into updating the adapter to adopt the ortb native allowing the overrides via the ad unit media type native.ortb object

@patmmccann
Copy link
Collaborator

After a bunch of discussion, i think we can merge this now, so up to you if you want to make edits or not

@jbartek25
Copy link
Contributor Author

ok. please merge then. @dgirardi is converting the Improve Digital adapter to ortb as part of #8738 so I'll make sure the default is overridable as part of that PR.

@patmmccann patmmccann merged commit a231b0d into prebid:master Aug 1, 2022
JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants